mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-05 18:20:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

devices: input: Removes used_desc_heads array.

Browse source 
Removes last usage of used_desc_heads/used_count pattern from crosvm.

BUG=None
TEST=cargo check

Change-Id: Ib80a22538f5d1e1c1055e0ea13156eb0ced15503
Reviewed-on: https://chromium-review.googlesource.com/1626327
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
This commit is contained in:
Jakub Staron 2019-05-23 11:22:10 -07:00 committed by chrome-bot
parent 96beafc1c1
commit 0854c168df
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
devices/src/virtio/input/mod.rs
View file

@ -402,9 +402,7 @@ impl<T: EventSource> Worker<T> {
// Send events from the source to the guest // Send events from the source to the guest
fn send_events(&mut self) -> bool { fn send_events(&mut self) -> bool {
let queue = &mut self.event_queue; let queue = &mut self.event_queue;
let mut needs_interrupt = false;
let mut used_desc_heads = [(0, 0); EVENT_QUEUE_SIZE as usize];
let mut used_count = 0;
// Only consume from the queue iterator if we know we have events to send // Only consume from the queue iterator if we know we have events to send
while self.event_source.available_events_count() > 0 { while self.event_source.available_events_count() > 0 {
@ -429,16 +427,14 @@ impl<T: EventSource> Worker<T> {
// length given in the queue descriptor are wrong. // length given in the queue descriptor are wrong.
panic!("failed reading events into guest memory: {}", e); panic!("failed reading events into guest memory: {}", e);
} }
used_desc_heads[used_count] = (avail_desc.index, len as u32);
used_count += 1; queue.add_used(&self.guest_memory, avail_desc.index, len as u32);
needs_interrupt = true;
} }
} }
} }
for &(desc_index, len) in &used_desc_heads[..used_count] {
queue.add_used(&self.guest_memory, desc_index, len);
}
used_count > 0 needs_interrupt
} }
fn process_status_queue(&mut self) -> Result<bool> { fn process_status_queue(&mut self) -> Result<bool> {