From 0ee9babf9cf9852748b930ec52e99052ebb4ae72 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Fri, 7 May 2021 12:31:50 -0700 Subject: [PATCH] rutabaga_gfx: replace u8 cast with byte literal Fixes clippy warning: "casting a character literal to `u8` truncates" https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 BUG=None TEST=bin/clippy Change-Id: I822de805f122ee14cc4856c36c9ef48de6432fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2885780 Tested-by: kokoro Commit-Queue: Daniel Verkamp Reviewed-by: Gurchetan Singh --- bin/clippy | 1 - rutabaga_gfx/src/virgl_renderer.rs | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/bin/clippy b/bin/clippy index bc623bd17e..a72634fa58 100755 --- a/bin/clippy +++ b/bin/clippy @@ -29,7 +29,6 @@ cd .. SUPPRESS=( # TODO(crbug/908640): To be resolved. borrowed_box - char_lit_as_u8 clone_on_copy collapsible_if comparison_chain diff --git a/rutabaga_gfx/src/virgl_renderer.rs b/rutabaga_gfx/src/virgl_renderer.rs index cdea147a3e..4850143825 100644 --- a/rutabaga_gfx/src/virgl_renderer.rs +++ b/rutabaga_gfx/src/virgl_renderer.rs @@ -88,7 +88,7 @@ impl Drop for VirglRendererContext { #[cfg(any(target_arch = "x86", target_arch = "x86_64"))] extern "C" fn debug_callback(fmt: *const ::std::os::raw::c_char, ap: *mut __va_list_tag) { let len: u32 = 256; - let mut c_str = CString::new(vec![' ' as u8; len as usize]).unwrap(); + let mut c_str = CString::new(vec![b' '; len as usize]).unwrap(); unsafe { let mut varargs = __va_list_tag { gp_offset: (*ap).gp_offset,