mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-05 18:20:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update ./tools/presubmit defaults and add --all mode

Browse source 
The new default should be quick, aarch64 tests barely take longer
than clippy/fmt and gives good enough coverage for most things.

The --all mode will add all other builds run by kokoro, including
armhf and a --no-default-features build.

BUG=b:203152778
TEST=./tools/presubmit (--quick, --all)

Change-Id: Ie778f397e9d65d9ca79bcb55acf0e74394bb04af
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3447293
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Dennis Kempin <denniskempin@google.com>
This commit is contained in:
Dennis Kempin 2022-02-08 15:20:53 -08:00
parent 4d0436e74e
commit 12ae5e8bc8
1 changed files with 20 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
tools/presubmit
View file

@ -23,9 +23,15 @@ All tests are executed in the local development environment. If your host is not
set up for aarch64 builds, it will use './tools/dev_container' to build run
those.
Aarch64 tests can be skipped with:
There are three levels of presubmit tests that can be run:
$ ./tools/presubmit --quick
$ ./tools/presubmit
$ ./tools/presubmit --all
The quick mode will only cover x86 and does not require a dev_container. The
default mode will add aarch64 tests, and the all mode will test everything that
is also tested on Kokoro.
"
while [[ $# -gt 0 ]]; do
@ -34,6 +40,10 @@ while [[ $# -gt 0 ]]; do
QUICK=true
shift
;;
-a | --all)
ALL=true
shift
;;
--tmux)
RUN_IN_TMUX=true
shift
@ -57,7 +67,7 @@ run_commands_in_tmux() {
)
for cmd in "${@:2}"; do
tmux_commands+=(
split-window "$cmd; read -p 'Press enter to close.'" \;
split-window -h "$cmd; read -p 'Press enter to close.'" \;
)
done
tmux_commands+=(
@ -83,13 +93,19 @@ aarch64_wrapper() {
commands=(
"./tools/fmt --check && ./tools/clippy"
"cargo build --verbose --no-default-features"
"./tools/run_tests --target=host"
)
if [ "$QUICK" != true ]; then
if [ "$ALL" == true ]; then
commands+=(
"$(aarch64_wrapper) ./tools/run_tests --target=vm:aarch64"
"$(aarch64_wrapper) ./tools/run_tests --target=vm:aarch64 --arch=armhf"
"cargo build --verbose --no-default-features"
)
elif [ "$QUICK" != true ]; then
commands+=(
# Test via user-space emulation for faster, but less complete results.
"$(aarch64_wrapper) ./tools/run_tests --target=host --arch=aarch64"
)
fi
@ -98,5 +114,3 @@ if [ "$RUN_IN_TMUX" = true ]; then
else
run_commands "${commands[@]}"
fi
# TODO(b/203152778): Add armhf builds to presubmit