From 15fadba6ea83363e72196b6a93b7eae7fc211a34 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Fri, 7 May 2021 12:53:41 -0700 Subject: [PATCH] devices: replace .into_iter() on ref with .iter() Fixes clippy warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref BUG=None TEST=bin/clippy Change-Id: Id31c3f6252b86a7f453ab4e6e7dac0ed6654bc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2885782 Tested-by: kokoro Commit-Queue: Daniel Verkamp Reviewed-by: Alexandre Courbot --- bin/clippy | 1 - devices/src/virtio/video/decoder/backend/vda.rs | 2 +- devices/src/virtio/video/encoder/mod.rs | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/bin/clippy b/bin/clippy index 8befd7545b..bf695dde6c 100755 --- a/bin/clippy +++ b/bin/clippy @@ -34,7 +34,6 @@ SUPPRESS=( extra_unused_lifetimes for_kv_map inefficient_to_string - into_iter_on_ref let_unit_value missing_safety_doc needless_range_loop diff --git a/devices/src/virtio/video/decoder/backend/vda.rs b/devices/src/virtio/video/decoder/backend/vda.rs index d167debcf0..8988b111d8 100644 --- a/devices/src/virtio/video/decoder/backend/vda.rs +++ b/devices/src/virtio/video/decoder/backend/vda.rs @@ -183,7 +183,7 @@ impl DecoderSession for libvda::decode::Session { planes: &[FramePlane], modifier: u64, ) -> VideoResult<()> { - let vda_planes: Vec = planes.into_iter().map(Into::into).collect(); + let vda_planes: Vec = planes.iter().map(Into::into).collect(); Ok(self.use_output_buffer( picture_buffer_id, libvda::PixelFormat::try_from(format)?, diff --git a/devices/src/virtio/video/encoder/mod.rs b/devices/src/virtio/video/encoder/mod.rs index 05d75de017..b572ddc125 100644 --- a/devices/src/virtio/video/encoder/mod.rs +++ b/devices/src/virtio/video/encoder/mod.rs @@ -628,7 +628,7 @@ impl EncoderDevice { let resource_info = get_resource_info(resource_bridge, uuid)?; let planes: Vec = resource_info.planes[0..num_planes] - .into_iter() + .iter() .map(|plane_info| VideoFramePlane { offset: plane_info.offset as usize, stride: plane_info.stride as usize,