mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-05 18:20:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

virtqueue: Re-enable notification suppression

Browse source 
Now that the get and set methods have the proper memory barriers it
should be safe to re-enable this.

BUG=none
TEST=crostini.Basic.buster_stable; reboot arcvm in a loop for 75
     iterations without observing a hang

Change-Id: I03271d838e31ad091536163359836bead7e00178
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3026690
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
This commit is contained in:
Chirantan Ekbote 2021-07-14 16:40:18 +09:00 committed by Commit Bot
parent 558460fe59
commit 1ac296b8d9
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
devices/src/virtio/queue.rs
View file

@ -532,13 +532,7 @@ impl Queue {
// so no need to inject new interrupt.
self.next_used - used_event - Wrapping(1) < self.next_used - self.last_used
} else {
// TODO(b/172975852): This branch should check the flag that requests interrupt
// supression:
// ```
// !self.get_avail_flag(mem, VIRTQ_AVAIL_F_NO_INTERRUPT)
// ```
// Re-enable the flag check once the missing interrupt issue is debugged.
true
!self.get_avail_flag(mem, VIRTQ_AVAIL_F_NO_INTERRUPT)
}
}