From 22b30eb15f0108ed5f151b308203d875a14112c5 Mon Sep 17 00:00:00 2001 From: Junichi Uekawa Date: Thu, 26 May 2022 09:51:19 +0900 Subject: [PATCH] crosvm: Use more semantically correct error type. It's not UnknownArgument, it's an unexpected argument. BUG=None TEST=build Change-Id: I990942c741d1e641697418a39ff55544d9fe4876 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3670094 Reviewed-by: Daniel Verkamp Tested-by: kokoro Commit-Queue: Junichi Uekawa --- src/main.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main.rs b/src/main.rs index 603f1c7cff..1a57245bb0 100644 --- a/src/main.rs +++ b/src/main.rs @@ -2145,7 +2145,7 @@ fn validate_arguments(cfg: &mut Config) -> std::result::Result<(), argument::Err if !cfg.userspace_msr.is_empty() { for (_, msr_config) in cfg.userspace_msr.iter() { if msr_config.from == MsrValueFrom::RWFromRunningCPU { - return Err(argument::Error::UnknownArgument( + return Err(argument::Error::ExpectedArgument( "`userspace-msr` must set `cpu0` if `host-cpu-topology` is not set" .to_owned(), )); @@ -2205,7 +2205,7 @@ fn validate_arguments(cfg: &mut Config) -> std::result::Result<(), argument::Err } } set_itmt_msr_config(&mut cfg.userspace_msr).map_err(|e| { - argument::Error::UnknownArgument(format!("the cpu doesn't support itmt {}", e)) + argument::Error::UnexpectedValue(format!("the cpu doesn't support itmt {}", e)) })?; } if !cfg.balloon && cfg.balloon_control.is_some() {