mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-05 10:10:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

integration_test: Do not throw away stdout/stderr.

Browse source 
When nothing fails, output is ignored, but when something fails, you'd
want to look at the error messages.

BUG=None
TEST=time ./builder --vm ./run_tests

Change-Id: If6e73588b33714dea1e7f097a91c80f7c249be48
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3083207
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Dennis Kempin <denniskempin@google.com>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
This commit is contained in:
Junichi Uekawa 2021-08-10 10:46:22 +09:00 committed by Commit Bot
parent ca0aed3daa
commit 3001c2fc73
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
integration_tests/tests/fixture.rs
View file

@ -3,6 +3,7 @@
// found in the LICENSE file.
use std::ffi::CString;
use std::fs::File;
use std::io::{self, BufRead, BufReader, Write};
use std::path::{Path, PathBuf};
use std::process::Command;
@ -11,7 +12,6 @@ use std::sync::Once;
use std::thread;
use std::time::Duration;
use std::{env, process::Child};
use std::{fs::File, process::Stdio};
use anyhow::{anyhow, Result};
use base::syslog;
@ -266,10 +266,7 @@ impl TestVm {
TestVm::configure_kernel(&mut command, o_direct);
println!("$ {:?}", command);
if !debug {
command.stdout(Stdio::null());
command.stderr(Stdio::null());
}
let process = command.spawn()?;
// Open pipes. Panic if we cannot connect after a timeout.