mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-11 12:35:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ac97: Skip flaky reg check in unit test

Browse source 
If the builder context switch to other tasks right after the
`bm.writeb`, then the results from `bm.readw` could be unexpected.

BUG=chromium:1086337
TEST=Build

Change-Id: I708b11ad3a556069a7b514f072222e913d91d643
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2330879
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
This commit is contained in:
paulhsia 2020-07-31 11:17:10 +08:00 committed by Commit Bot
parent 1d0f16005d
commit 36067153bf
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
devices/src/pci/ac97_bus_master.rs
View file

@ -1142,7 +1142,8 @@ mod test {
// Start. // Start.
bm.writeb(PI_CR_0B, CR_IOCE | CR_RPBM, &mixer); bm.writeb(PI_CR_0B, CR_IOCE | CR_RPBM, &mixer);
assert_eq!(bm.readw(PI_PICB_08), 0); // TODO(crbug.com/1086337): Test flakiness in build time.
// assert_eq!(bm.readw(PI_PICB_08), 0);
let mut stream = stream_source.get_last_stream(); let mut stream = stream_source.get_last_stream();
assert!(stream.trigger_callback_with_timeout(TIMEOUT)); assert!(stream.trigger_callback_with_timeout(TIMEOUT));