mirror of
https://chromium.googlesource.com/crosvm/crosvm
synced 2025-02-10 12:09:31 +00:00
rutabaga: Don't enable all features for Vulkano device
Some devices support so many features, that they collide. In Vulkano's autogenerated out\features.rs, some are tagged as: crate::device::FeatureRestriction::ConflictsFeature Meaning both cannot be on at the same time. An example failure is on Nvidia for: shading_rate_image attachment_fragment_shading_rate My GPU supports both and thus cannot be created since we attempt to enable all supported features. This is VUID 04480 https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkDeviceCreateInfo-shadingRateImage-04480 This change just removes features from being requested. Instead we should choose the specific features we want as they come up. Currently for GPU mapping we don't need features. BUG=b:244622199 TEST=downstream Change-Id: Ic511d04cf2987bfc7189182a1dc002a367b5d9f7 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3936679 Commit-Queue: Idan Raiter <idanr@google.com> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
This commit is contained in:
parent
f4d2214077
commit
3e19680831
1 changed files with 0 additions and 1 deletions
|
@ -152,7 +152,6 @@ impl VulkanoGralloc {
|
|||
if let Ok((device, mut _queues)) = Device::new(
|
||||
physical.clone(),
|
||||
DeviceCreateInfo {
|
||||
enabled_features: physical.supported_features().clone(),
|
||||
enabled_extensions: intersection,
|
||||
queue_create_infos: vec![QueueCreateInfo {
|
||||
queue_family_index: queue_family_index as u32,
|
||||
|
|
Loading…
Reference in a new issue