From 4c2fa9d76d3024a2095f4b2a2454856f73735f8d Mon Sep 17 00:00:00 2001
From: Daniel Verkamp <dverkamp@chromium.org>
Date: Thu, 16 May 2024 17:40:01 -0700
Subject: [PATCH] Fix clippy::assigning_clones lints

Use the potentially more efficient clone_from() function when cloning
and assigning.

BUG=b:344974550
TEST=tools/clippy

Change-Id: I0601b59a80fdebbc09b212110c6e68e23a52bcfe
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5604659
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
---
 cros_fdt/src/overlay.rs                              | 2 +-
 devices/src/virtio/snd/common_backend/stream_info.rs | 2 +-
 src/main.rs                                          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cros_fdt/src/overlay.rs b/cros_fdt/src/overlay.rs
index 5b685a40d2..9068820d4d 100644
--- a/cros_fdt/src/overlay.rs
+++ b/cros_fdt/src/overlay.rs
@@ -161,7 +161,7 @@ fn do_overlay_filter(filtered_paths: Vec<Path>, overlay: &mut Fdt) {
             tgt_node = tgt_node
                 .subnode_mut(node_name)
                 .expect("filtered paths reference valid nodes");
-            tgt_node.props = src_node.props.clone();
+            tgt_node.props.clone_from(&src_node.props);
         }
     }
     overlay.root = new_root;
diff --git a/devices/src/virtio/snd/common_backend/stream_info.rs b/devices/src/virtio/snd/common_backend/stream_info.rs
index 9e7c99e200..bb6d487625 100644
--- a/devices/src/virtio/snd/common_backend/stream_info.rs
+++ b/devices/src/virtio/snd/common_backend/stream_info.rs
@@ -451,7 +451,7 @@ impl StreamInfo {
         self.buffer_bytes = state.buffer_bytes;
         self.period_bytes = state.period_bytes;
         self.direction = state.direction;
-        self.effects = state.effects.clone();
+        self.effects.clone_from(&state.effects);
         self.just_reset = state.just_reset;
     }
 }
diff --git a/src/main.rs b/src/main.rs
index 4b7eca2591..be98c8ec93 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -763,7 +763,7 @@ fn crosvm_main<I: IntoIterator<Item = String>>(args: I) -> Result<CommandStatus>
                          `crosvm --syslog-tag=\"{}\" run` instead",
                         syslog_tag
                     );
-                    log_config.log_args.proc_name = syslog_tag.clone();
+                    log_config.log_args.proc_name.clone_from(syslog_tag);
                 }
                 // We handle run_vm separately because it does not simply signal success/error
                 // but also indicates whether the guest requested reset or stop.