Enable vaapi feature upstream

The feature can be built but not tested without access to an intel
GPU.
To enable the build, the testvm and dev container are updated to
include libva.

BUG=b:244619376
TEST=presubmit

Change-Id: Ia8c4dc46ccbcd244bf57441f2c550a6b73c67b1c
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3946027
Commit-Queue: Dennis Kempin <denniskempin@google.com>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>

Cargo.toml

@@ -280,6 +280,7 @@ all-aarch64 = [
     "power-monitor-powerd",
     "slirp",
     "tpm",
+    "vaapi",
     "video-decoder",
     "virgl_renderer_next",
     "virgl_renderer",

devices/src/virtio/video/encoder/encoder.rs

@@ -40,6 +40,7 @@ pub enum EncoderEvent {
     FlushResponse {
         flush_done: bool,
     },
+    #[allow(dead_code)]
     NotifyError {
         error: VideoError,
     },

tools/health-check

@@ -114,7 +114,6 @@ KNOWN_DISABLED_FEATURES = [
     "direct",
     "gfxstream",
     "libvda",
-    "vaapi",
     "video-encoder",
     "whpx",
 ]

tools/impl/dev_container/version

@@ -1 +1 @@
-r0025
+r0026

tools/impl/testvm.py

@@ -17,8 +17,6 @@ from contextlib import closing
 from pathlib import Path
 from typing import Dict, Iterable, List, Literal, Optional, Tuple
 
-# Cache busting 1
-
 USAGE = """%(prog)s {command} [options]
 
 Manages VMs for testing crosvm.

tools/impl/testvm/cloud_init.yaml

@@ -20,13 +20,6 @@ users:
 
 preserve_hostname: true
 
-{% if v1.machine == 'aarch64' -%}
-# This needs to run as bootcmd to preceed processing `packages` section
-bootcmd:
-    - dpkg --add-architecture armhf
-{%- endif %}
-
-
 # Runtime dependencies of crosvm binaries.
 # Note: Keep in sync with ./install-[aarch64-]deps.sh
 packages:
@@ -38,19 +31,11 @@ packages:
     - libepoxy0
     - libssl3
     - libswscale6
+    - libva2
     - libwayland-client0
     - libx11-6
     - libxext6
     - rsync
-{% if v1.machine == 'aarch64' %}
-    # We run armhf tests on the aarch64 VM. But only some, install the needed runtime
-    # dependencies for those.
-    - libcap2:armhf
-    - libssl3:armhf
-    - libx11-6:armhf
-    - libwayland-client0:armhf
-    - libepoxy0:armhf
-{%- endif %}
 
 # Commands to run once during setup
 runcmd:

tools/impl/testvm/version

@@ -1 +1 @@
-r0004
+r0006

tools/install-aarch64-deps

@@ -16,6 +16,8 @@ sudo apt-get install --yes --no-install-recommends \
     libepoxy-dev:arm64 \
     libssl-dev:arm64 \
     libswscale-dev:arm64 \
+    libudev-dev:arm64 \
+    libva-dev:arm64 \
     libwayland-dev:arm64 \
     libxext-dev:arm64 \
     qemu-efi-aarch64 \