mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-05 18:20:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

vmm_vhost: Add TODO comments about IoSlice::advance_slice()

Browse source 
BUG=b:194137301
TEST=cargo test

Change-Id: I28466597209e4e81dc566d66d69875f59808eb0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3317325
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
This commit is contained in:
Keiichi Watanabe 2021-12-06 23:14:35 +09:00 committed by Commit Bot
parent 7d4d02fc94
commit 5f5f6afacd
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
third_party/vmm_vhost/src/connection.rs vendored
View file

@ -111,6 +111,12 @@ pub trait EndpointExt<R: Req>: Endpoint<R> {
///
/// # Return:
/// * - number of bytes sent on success
///
/// # TODO
/// This function takes a slice of `&[u8]` instead of `IoSlice` because the internal
/// cursor needs to be moved by `advance_slices()`.
/// Once `IoSlice::advance_slices()` becomes stable, this should be updated.
/// <https://github.com/rust-lang/rust/issues/62726>.
fn send_iovec_all(
&mut self,
mut iovs: &mut [&[u8]],
@ -246,6 +252,12 @@ pub trait EndpointExt<R: Req>: Endpoint<R> {
/// * - (number of bytes received, [received fds]) on success
/// * - SocketBroken: the underline socket is broken.
/// * - SocketError: other socket related errors.
///
/// # TODO
/// This function takes a slice of `&mut [u8]` instead of `IoSliceMut` because the internal
/// cursor needs to be moved by `advance_slices_mut()`.
/// Once `IoSliceMut::advance_slices()` becomes stable, this should be updated.
/// <https://github.com/rust-lang/rust/issues/62726>.
fn recv_into_bufs_all(
&mut self,
mut bufs: &mut [&mut [u8]],