mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-10 12:09:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

crosvm: pci: prefer to/from le_bytes instead of manual byte manipulation

Browse source 
Change-Id: I6f7d18662d546e6d76af349de0633f2c99f3e44d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3508319
Reviewed-by: Anton Romanov <romanton@google.com>
Auto-Submit: Anton Romanov <romanton@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
This commit is contained in:
Anton Romanov 2022-03-07 22:58:14 +00:00 committed by Commit Bot
parent d6a42bdf6c
commit 6fd8926373
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
devices/src/pci/pci_root.rs
View file

@ -456,10 +456,7 @@ impl BusDevice for PciVirtualConfigMmio {
.lock()
.virtual_config_space_read(address, register)
};
data[0] = value as u8;
data[1] = (value >> (1 * 8)) as u8;
data[2] = (value >> (2 * 8)) as u8;
data[3] = (value >> (3 * 8)) as u8;
data[0..4].copy_from_slice(&value.to_le_bytes()[..]);
}
fn write(&mut self, info: BusAccessInfo, data: &[u8]) {
@ -472,10 +469,8 @@ impl BusDevice for PciVirtualConfigMmio {
);
return;
}
let value = (data[0] as u32)
| ((data[1] as u32) << (1 * 8))
| ((data[2] as u32) << (2 * 8))
| ((data[3] as u32) << (3 * 8));
// Unwrap is safe as we verified length above
let value = u32::from_le_bytes(data.try_into().unwrap());
let (address, register) =
PciAddress::from_config_address(info.offset as u32, self.register_bit_num);
self.pci_root