mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-10-22 20:36:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix clippy::suspicious_open_options warnings

Browse source 
Use .create_new() rather than .create() for cases where we always want
to ensure that the file does not already exist, and add .truncate(false)
for a case where we do want to open an existing file and don't want to
overwrite it.

BUG=b:344974550
TEST=tools/clippy

Change-Id: Ie82a6db306532c600c140efab3d310b6c7cf25a7
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5604660
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
This commit is contained in:
Daniel Verkamp 2024-04-08 12:39:42 -07:00 committed by crosvm LUCI
parent 4c2fa9d76d
commit 7cf3dcacbf
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
disk/src/qcow/mod.rs
View file

@ -2470,7 +2470,7 @@ mod tests {
let _backing_file = OpenOptions::new()
.read(true)
.write(true)
.create(true)
.create_new(true)
.open(&backing_file_path)
.unwrap();
@ -2478,7 +2478,7 @@ mod tests {
let level1_qcow_file = OpenOptions::new()
.read(true)
.write(true)
.create(true)
.create_new(true)
.open(&level1_qcow_file_path)
.unwrap();
let _level1_qcow_file = QcowFile::new_from_backing(

4
io_uring/tests/uring.rs
View file

@ -308,8 +308,7 @@ fn fallocate_fsync() {
let mut f = OpenOptions::new()
.read(true)
.write(true)
.create(true)
.truncate(true)
.create_new(true)
.open(&file_path)
.unwrap();
f.write_all(&buf).unwrap();
@ -321,6 +320,7 @@ fn fallocate_fsync() {
.read(true)
.write(true)
.create(true)
.truncate(false)
.open(&file_path)
.unwrap();