From 84f0f4f0680c587c1f0d05b25e463f01a1c5d7b2 Mon Sep 17 00:00:00 2001 From: Dennis Kempin Date: Mon, 15 Aug 2022 19:05:24 +0000 Subject: [PATCH] tools/health-check: Remove legacy checks used by Luci Since luci recipes are updated asynchronously, we had to keep the old check names around. Now that all builders are updated, we can remove it. BUG=b:239255137 TEST=CQ Change-Id: I0550912d466045e12da1717cdb96346de9474ab7 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3831283 Tested-by: Dennis Kempin Reviewed-by: Daniel Verkamp Commit-Queue: Dennis Kempin --- tools/health-check | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/tools/health-check b/tools/health-check index a2dbfdf19e..9c30ec745b 100755 --- a/tools/health-check +++ b/tools/health-check @@ -117,16 +117,13 @@ CHECKS: List[Check] = [ CHECKS_DICT = dict((c.name, c) for c in CHECKS) -# TODO(b/239255137): Remove after transition -LEGACY_STEPS = ["python", "misc", "fmt", "clippy"] - @argh.arg("--list-checks", default=False, help="List names of available checks and exit.") @argh.arg("--fix", default=False, help="Asks checks to fix problems where possible.") @argh.arg("--all", default=False, help="Run on all files instead of just modified files.") @argh.arg( "checks", - choices=[*CHECKS_DICT.keys(), *LEGACY_STEPS, []], + choices=[*CHECKS_DICT.keys(), []], help="Optional list of checks to run. Defaults to run all checks.", ) def main( @@ -141,26 +138,10 @@ def main( """ chdir(CROSVM_ROOT) - # We need to support the old arguments while Luci is transitioning. - # TODO(b/239255137): Remove after transition - no_legacy_checks = [check for check in checks if check not in LEGACY_STEPS] - if "python" in checks: - no_legacy_checks += ["python_tests", "python_types"] - all = True - if "clippy" in checks: - no_legacy_checks += ["rust_clippy"] - all = True - if "misc" in checks: - no_legacy_checks += ["crlf_line_endings"] - all = True - if "fmt" in checks: - no_legacy_checks += ["python_format", "markdown_format", "rust_format"] - all = True - - if not no_legacy_checks: + if not checks: checks_list = [*CHECKS_DICT.values()] else: - checks_list = [CHECKS_DICT[check] for check in no_legacy_checks] + checks_list = [CHECKS_DICT[check] for check in checks] if list_checks: for check in checks_list: