mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-01-28 19:29:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix a typo: virtio::NOITFY_REG_OFFSET -> virtio::NOTIFY_REG_OFFSET

Browse source 
TEST=compiled crosvm successfully

Change-Id: Idabf81b8600fa2772e6e315d08d3c853e511a8cd
Reviewed-on: https://chromium-review.googlesource.com/1023415
Commit-Ready: Philipp Kern <pkern@google.com>
Tested-by: Philipp Kern <pkern@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
This commit is contained in:
Philipp Kern 2018-04-23 09:31:53 +02:00 committed by chrome-bot
parent 6ed5aea011
commit a894f53439
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
device_manager/src/device_manager.rs
View file

@ -104,7 +104,7 @@ impl<'a> DeviceManager<'a> {
.map_err(Error::CreateMmioDevice)?;
for (i, queue_evt) in mmio_device.queue_evts().iter().enumerate() {
let io_addr = IoeventAddress::Mmio(self.mmio_base +
devices::virtio::NOITFY_REG_OFFSET as u64);
devices::virtio::NOTIFY_REG_OFFSET as u64);
self.vm
.register_ioevent(&queue_evt, io_addr, i as u32)
.map_err(Error::RegisterIoevent)?;

4
devices/src/virtio/mmio.rs
View file

@ -81,7 +81,7 @@ pub trait VirtioDevice: Send {
/// This requires 3 points of installation to work with a VM:
///
/// 1. Mmio reads and writes must be sent to this device at what is referred to here as MMIO base.
/// 1. `Mmio::queue_evts` must be installed at `virtio::NOITFY_REG_OFFSET` offset from the MMIO
/// 1. `Mmio::queue_evts` must be installed at `virtio::NOTIFY_REG_OFFSET` offset from the MMIO
/// base. Each event in the array must be signaled if the index is written at that offset.
/// 1. `Mmio::interrupt_evt` must signal an interrupt that the guest driver is listening to when it
/// is written to.
@ -133,7 +133,7 @@ impl MmioDevice {
}
/// Gets the list of queue events that must be triggered whenever the VM writes to
/// `virtio::NOITFY_REG_OFFSET` past the MMIO base. Each event must be triggered when the
/// `virtio::NOTIFY_REG_OFFSET` past the MMIO base. Each event must be triggered when the
/// value being written equals the index of the event in this list.
pub fn queue_evts(&self) -> &[EventFd] {
self.queue_evts.as_slice()

2
devices/src/virtio/mod.rs
View file

@ -41,4 +41,4 @@ const INTERRUPT_STATUS_CONFIG_CHANGED: u32 = 0x2;
/// Offset from the base MMIO address of a virtio device used by the guest to notify the device of
/// queue events.
pub const NOITFY_REG_OFFSET: u32 = 0x50;
pub const NOTIFY_REG_OFFSET: u32 = 0x50;