mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-06 02:25:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enable seccomp for virtio-fs

Browse source 
Add x86_64 and arm seccomp policy files for the virtio-fs device.

BUG=b:136128319
TEST=Run a vm with a sandboxed virtio-fs device

Change-Id: I8ea7c5d3e90696077f0c2b1f942cb286a0b36cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1916559
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
This commit is contained in:
Chirantan Ekbote 2019-11-14 18:45:56 +09:00 committed by Commit Bot
parent bd4723b218
commit b0ac00745a
3 changed files with 72 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
seccomp/arm/fs_device.policy Normal file
View file

@ -0,0 +1,32 @@
# Copyright 2019 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
openat: 1
@include /usr/share/policy/crosvm/common_device.policy
fchmodat: 1
fchownat: 1
fgetxattr: 1
fsetxattr: 1
fstatat64: 1
fstatfs64: 1
ftruncate64: 1
getdents64: 1
getegid: 1
geteuid: 1
linkat: 1
_llseek: 1
mkdirat: 1
mknodat: 1
preadv: 1
pwritev: 1
readlinkat: 1
renameat2: 1
setresgid: 1
setresuid: 1
symlinkat: 1
umask: 1
unlinkat: 1
utimensat: 1

32
seccomp/x86_64/fs_device.policy Normal file
View file

@ -0,0 +1,32 @@
# Copyright 2019 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
openat: 1
@include /usr/share/policy/crosvm/common_device.policy
fchmodat: 1
fchownat: 1
fgetxattr: 1
fsetxattr: 1
fstatfs: 1
ftruncate: 1
getdents64: 1
getegid: 1
geteuid: 1
linkat: 1
lseek: 1
mkdirat: 1
mknodat: 1
newfstatat: 1
preadv: 1
pwritev: 1
readlinkat: 1
renameat2: 1
setresgid: 1
setresuid: 1
symlinkat: 1
umask: 1
unlinkat: 1
utimensat: 1

17
src/linux.rs
View file

@ -761,17 +761,16 @@ fn create_fs_device(
j.no_new_privs(); j.no_new_privs();
// TODO(chirantan): Enable seccomp
// Use TSYNC only for the side effect of it using SECCOMP_RET_TRAP, which will correctly kill // Use TSYNC only for the side effect of it using SECCOMP_RET_TRAP, which will correctly kill
// the entire device process if a worker thread commits a seccomp violation. // the entire device process if a worker thread commits a seccomp violation.
// let seccomp_policy = cfg.seccomp_policy_dir.join("9p_device.policy"); let seccomp_policy = cfg.seccomp_policy_dir.join("fs_device.policy");
// j.set_seccomp_filter_tsync(); j.set_seccomp_filter_tsync();
// if cfg.seccomp_log_failures { if cfg.seccomp_log_failures {
// j.log_seccomp_filter_failures(); j.log_seccomp_filter_failures();
// } }
// j.parse_seccomp_filters(&seccomp_policy) j.parse_seccomp_filters(&seccomp_policy)
// .map_err(Error::DeviceJail)?; .map_err(Error::DeviceJail)?;
// j.use_seccomp_filter(); j.use_seccomp_filter();
// Don't do init setup. // Don't do init setup.
j.run_as_init(); j.run_as_init();