From b59b1089308b99b5ec752e2de10628facf580b86 Mon Sep 17 00:00:00 2001 From: Frederick Mayle Date: Tue, 2 Aug 2022 01:19:36 +0000 Subject: [PATCH] base: syslog: Fix android build bionic (the android libc) doesn't have shm_open or shm_unlink. TEST=presubmit BUG=b:228881485 Change-Id: Ic0df86387a1110835b1e53a68d249fa3d55803ab Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3803896 Reviewed-by: Devin Moore Auto-Submit: Frederick Mayle Tested-by: Frederick Mayle Reviewed-by: Dennis Kempin Commit-Queue: Dennis Kempin --- base/src/sys/unix/syslog.rs | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/base/src/sys/unix/syslog.rs b/base/src/sys/unix/syslog.rs index cad0cd2621..ea26af85f4 100644 --- a/base/src/sys/unix/syslog.rs +++ b/base/src/sys/unix/syslog.rs @@ -14,11 +14,16 @@ mod tests { use std::io::SeekFrom; use std::os::unix::io::FromRawFd; - use libc::shm_open; - use libc::shm_unlink; - use libc::O_CREAT; - use libc::O_EXCL; - use libc::O_RDWR; + cfg_if::cfg_if! { + // ANDROID: b/228881485 + if #[cfg(not(target_os = "android"))] { + use libc::shm_open; + use libc::shm_unlink; + use libc::O_CREAT; + use libc::O_EXCL; + use libc::O_RDWR; + } + } use crate::syslog::*; @@ -34,6 +39,7 @@ mod tests { } #[test] + #[cfg(not(target_os = "android"))] // ANDROID: b/228881485 fn syslog_file() { ensure_inited().unwrap(); let shm_name = CStr::from_bytes_with_nul(b"/crosvm_shm\0").unwrap();