From b792ffdcec10fc40e22e639722e30145a6a2a47b Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Mon, 10 May 2021 14:13:16 -0700 Subject: [PATCH] devices: vios: remove unnecessary mut reference The seq_socket_send() function only requires a non-mutable reference; drop the mut. Fixes clippy warning "the function `seq_socket_send` doesn't need a mutable reference". BUG=None TEST=bin/clippy Change-Id: I517a8d782601f33653db33c201666707beddd5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2885787 Tested-by: kokoro Commit-Queue: Daniel Verkamp Reviewed-by: Zach Reizner Reviewed-by: Jorge Moreira Broche Reviewed-by: Dylan Reid --- bin/clippy | 1 - devices/src/virtio/snd/vios_backend/shm_vios.rs | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/bin/clippy b/bin/clippy index 236ad3c180..cd1a2480e3 100755 --- a/bin/clippy +++ b/bin/clippy @@ -41,7 +41,6 @@ SUPPRESS=( range_plus_one slow_vector_initialization unnecessary_filter_map - unnecessary_mut_passed unneeded_field_pattern useless_format wrong_self_convention diff --git a/devices/src/virtio/snd/vios_backend/shm_vios.rs b/devices/src/virtio/snd/vios_backend/shm_vios.rs index 171566aa33..21a2d62b6a 100644 --- a/devices/src/virtio/snd/vios_backend/shm_vios.rs +++ b/devices/src/virtio/snd/vios_backend/shm_vios.rs @@ -364,7 +364,7 @@ impl VioSClient { fn send_cmd(&self, data: T) -> Result<()> { let mut control_socket_lock = self.control_socket.lock(); - seq_socket_send(&mut *control_socket_lock, data)?; + seq_socket_send(&*control_socket_lock, data)?; recv_cmd_status(&mut *control_socket_lock) }