From c1b656f46c545135e274e9a968d1c93d8474c4d5 Mon Sep 17 00:00:00 2001 From: Dennis Kempin Date: Wed, 31 Aug 2022 20:02:15 +0000 Subject: [PATCH] tools/presubmit: Align with tests in CI presubmit has slightly diverged from what we are runnning in CI, so things like running tests with user space emulation tend to break. This should make sure that presubmit continues to work. We can utilized user-space emulation as when we reorganize our tests to have unit tests that do not have special system requirements. Then CI will be running those tests with user-space emulation as well. BUG=b:244185215 TEST=./tools/presubmit [--quick/--all] Change-Id: I46f6498ad030ad50d42d3365c908a16e6573b5d7 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3867535 Commit-Queue: Dennis Kempin Tested-by: Dennis Kempin Reviewed-by: Daniel Verkamp --- tools/presubmit | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/presubmit b/tools/presubmit index 627b4369df..5a5a636da1 100755 --- a/tools/presubmit +++ b/tools/presubmit @@ -105,8 +105,7 @@ if [ "$ALL" == true ]; then ) elif [ "$QUICK" != true ]; then commands+=( - # Test via user-space emulation for faster, but less complete results. - "$(aarch64_wrapper) ./tools/run_tests --target=host --build-target=aarch64" + "$(aarch64_wrapper) ./tools/run_tests --target=vm:aarch64" "./tools/run_tests --target=host --build-target=mingw64 --build-only" ) fi