mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-06 02:25:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

devices: fix compile warnings in tests

Browse source 
Fix a few compilation warnings in our tests:

* The PCI device had an unused argument without a leading underscore in
  the name ;
* The virtio queue is dereferencing null pointers, which is UB albeit
  technically ok in this case (bindgen generates similar tests too [1]).

[1] https://github.com/rust-lang/rust-bindgen/issues/1651

BUG=None
TEST=cargo test in devices/ does not show these warnings anymore.

Change-Id: Id272b5381f80bb72d96839a5a6da8bb0c644502d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3418623
Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Dennis Kempin <denniskempin@google.com>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
This commit is contained in:
Alexandre Courbot 2022-01-26 16:46:47 +09:00 committed by Commit Bot
parent 145f452cf5
commit c61125c154
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
devices/src/pci/pci_device.rs
View file

@ -407,7 +407,7 @@ mod tests {
fn write_bar(&mut self, _addr: u64, _data: &[u8]) {}
fn allocate_address(&mut self, resources: &mut SystemAllocator) -> Result<PciAddress> {
fn allocate_address(&mut self, _resources: &mut SystemAllocator) -> Result<PciAddress> {
Err(Error::PciAllocationFailed)
}

2
devices/src/virtio/queue.rs
View file

@ -677,6 +677,7 @@ mod tests {
);
// Calculating the offset of used_event within Avail structure
#[allow(deref_nullptr)]
let used_event_offset: u64 =
unsafe { &(*(::std::ptr::null::<Avail>())).used_event as *const _ as u64 };
let used_event_address = GuestAddress(AVAIL_OFFSET + used_event_offset);
@ -753,6 +754,7 @@ mod tests {
);
// Calculating the offset of used_event within Avail structure
#[allow(deref_nullptr)]
let used_event_offset: u64 =
unsafe { &(*(::std::ptr::null::<Avail>())).used_event as *const _ as u64 };
let used_event_address = GuestAddress(AVAIL_OFFSET + used_event_offset);