From d8d9556184d1eb84879045283b2b1a68f1b56fd2 Mon Sep 17 00:00:00 2001 From: Keiichi Watanabe Date: Fri, 10 Apr 2020 20:14:28 +0900 Subject: [PATCH] docker: Put libvda.pc under /pkgconfig/ Put a dummy pc file for libvda under /docker/pkgconfig/ instead of generating at the runtime. This is a fix for CL:2133987, but shouldn't change any behavior. BUG=none TEST=build_crosvm_base.sh && build_crosvm.sh with CL:1973973 Change-Id: Ifd7677abf14346ca2e7a9bc48b5ebb6c519b78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2145533 Tested-by: Keiichi Watanabe Tested-by: kokoro Reviewed-by: Daniel Verkamp Commit-Queue: Keiichi Watanabe --- docker/Dockerfile | 6 ++---- docker/pkgconfig/libvda.pc | 4 ++++ 2 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 docker/pkgconfig/libvda.pc diff --git a/docker/Dockerfile b/docker/Dockerfile index 1bd1086070..995ff9b232 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -124,9 +124,6 @@ RUN git clone https://chromium.googlesource.com/chromiumos/platform2 $PLATFORM2_ && cp librendernodehost.a /lib \ && git clean -f -# Create a dummy pc file for libvda to run 'cargo check' with video features. -RUN echo "Name: libvda_pc\nDescription:\nVersion:0.1\nLibs: -lvda" > /usr/lib/pkgconfig/libvda.pc - # Set up sysroot from which system_api proto files are built. ENV SYSROOT=/sysroot RUN mkdir -p $SYSROOT/usr/include/chromeos/dbus/trunks \ @@ -134,7 +131,8 @@ RUN mkdir -p $SYSROOT/usr/include/chromeos/dbus/trunks \ $SYSROOT/usr/include/chromeos/dbus/trunks # Inform pkg-config where libraries we install are placed. -COPY pkgconfig/* /usr/lib/pkgconfig +# Also, copy a dummy libvda.pc to compile crosvm with video features. +COPY pkgconfig/* /usr/lib/pkgconfig/ # Reduces image size and prevents accidentally using /scratch files RUN rm -r /scratch /usr/bin/meson diff --git a/docker/pkgconfig/libvda.pc b/docker/pkgconfig/libvda.pc new file mode 100644 index 0000000000..ee57864afc --- /dev/null +++ b/docker/pkgconfig/libvda.pc @@ -0,0 +1,4 @@ +Name: libvda +Description: CrOS VDA Connection Library +Version: 0.1 +Libs: -lvda