mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-05 18:20:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

sys_util: drop redundant empty return type

Browse source 
rustfmt incorrectly formats the `handler` parameter in
register_signal_handler in a way that actually breaks compilation.

This bug has been reported upstream already, but it is not fixed yet on
the version of rustfmt available with stable rust:
https://github.com/rust-lang/rustfmt/issues/3673

However, the empty return type can just be omitted in this case, which
avoids the rustfmt bug.

BUG=None
TEST=`bin/fmt --check` passes with Rust 1.36.0

Change-Id: I75c49c66f1db9cb6ae73cc0f6f3e66351176c474
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1724849
Reviewed-by: Zach Reizner <zachr@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Daniel Verkamp 2019-07-29 10:28:09 -07:00 committed by Commit Bot
parent 2ea297ac76
commit fb32e98f86
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys_util/src/signal.rs
View file

@ -100,10 +100,7 @@ fn valid_signal_num(num: c_int) -> bool {
/// ///
/// This is considered unsafe because the given handler will be called asynchronously, interrupting /// This is considered unsafe because the given handler will be called asynchronously, interrupting
/// whatever the thread was doing and therefore must only do async-signal-safe operations. /// whatever the thread was doing and therefore must only do async-signal-safe operations.
pub unsafe fn register_signal_handler( pub unsafe fn register_signal_handler(num: c_int, handler: extern "C" fn()) -> errno::Result<()> {
num: c_int,
handler: extern "C" fn() -> (),
) -> errno::Result<()> {
if !valid_signal_num(num) { if !valid_signal_num(num) {
return Err(errno::Error::new(EINVAL)); return Err(errno::Error::new(EINVAL));
} }