mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-11 12:35:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
2476 commits 607 branches 2 tags 237 MiB
Commit graph

5 commits

Author SHA1 Message Date
Kuo-Hsin Yang
1b21dec7b1 data_model: Add safety section for unsafe functions 
When running presubmit for a module depends on sys_util, clippy shows
the following error message.

error: unsafe function's docs miss `# Safety` section
  --> .../src/platform/crosvm/data_model/src/flexible_array.rs:77:5
   |
77 |     unsafe fn get_slice(&self, len: usize) -> &[S];
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D clippy::missing-safety-doc` implied by `-D warnings`

BUG=none
TEST=Cq preflight

Change-Id: If296f145b68d6c2734a0fb58b37fd0452791aed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2879285
Reviewed-by: Kuo-Hsin Yang <vovoy@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Auto-Submit: Kuo-Hsin Yang <vovoy@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org>
 2021-05-18 17:44:19 +00:00
Gurchetan Singh
538128dc98 data_model: add flexible_array_impl! macro 
- Removes duplicated code
- Assumes "u32" as the type of the flexible array
  length field, which should be fine.

BUG=b:173630595
TEST=compile and run

Change-Id: Ia2d9f74b823e06d2f2f0b60cebb8a3b999a9cba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2848283
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Auto-Submit: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>
 2021-04-30 20:49:53 +00:00
Daniel Verkamp
4e464ae6ab data_model: fix flexible_array doc tests 
Mark the FlexibleArray doc comment code block as ignored so it does not
fail when tested with `cargo test -p data_model` (this is not a full
example, since it is missing the __IncompleteArrayField struct that is
typically provided by bindgen).  Also fix a missing comma to at least
make the syntax valid.

BUG=None
TEST=cargo test -p data_model

Change-Id: Ic07daae1599df8afb272cda4f12b5f47b443f2c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2535351
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
 2020-11-16 22:42:58 +00:00
Gurchetan Singh
cf68ea6f3e crosvm: finish up flexible array wrapper 
We added the file, but forgot the flexible array. Fix this.

BUG=chromium:892806
TEST=kvm/hypervisor tests pass, atlas tryjobs pass

Change-Id: Ic52d3c9a9e67f1619151a08d3dd0e879de658066
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2347068
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>
 2020-10-02 03:28:07 +00:00
Gurchetan Singh
bf433ea9f6 crosvm: move vec_with_array_field to data_model 
Move it to the newly created flexible array file.

BUG=chromium:892806
TEST=compiles

Change-Id: I6c423a885cec17e376b0da87a4adbd17c71ff6f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1325510
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
 2019-12-11 00:34:36 +00:00