mirror of
https://chromium.googlesource.com/crosvm/crosvm
synced 2025-02-09 03:57:24 +00:00
303c285b7f
Currently, --async-executor option to switch the backend of cros_async::Executor is a global option of crosvm main command. This is because --async-executor is an option to switch the async runtime backend engine of cros_async crate for a whole crosvm. However, in practice, only run, device, and devices subcommands have the motivation to switch the backends for the performance. Other subcommands may or may not use async functions, but it's unlikely they want to switch the backends. So, it makes sense to make --async-executor an option of those three subcommands, not of the global option. Also, it allows us to switch --async-executor in arvm_dev.conf, which overrides the options for `crosvm run` command, and to control the async executor by the coming configuration file feature. Thus, this commit moves the --async-executor option from the global command to the run, device, and devices subcommands. This is a breaking change, but it is unlikely to have many users using this relatively new option. Takayas also confirmed there's no usage on codesearch. BUG=b:251289312 TEST=confirmed `crosvm --log-level debug run --async-executor ...` switches the executor with additional debug log in the coming CL. TEST=confirmed `crosvm --log-level debug device --async-executor ...` switches the executor with additional debug log in the coming CL. TEST=confirmed `crosvm --log-level debug devices --async-executor ...` switches the executor with additional debug log in the coming CL. TEST=./tools/dev_container ./tools/presubmit Change-Id: Ia25f2d0b296b8d73f31d71c362e5f90678166d96 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4005473 Auto-Submit: Takaya Saeki <takayas@chromium.org> Commit-Queue: Takaya Saeki <takayas@chromium.org> Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> |
||
|---|---|---|
| .. | ||
| src | ||
| Cargo.toml | ||