mirror of
https://chromium.googlesource.com/crosvm/crosvm
synced 2025-02-06 02:25:23 +00:00
c5dad3fdee
When outputting a picture there is a bit of code that updates the size of each output plane to the size of the visible rect. This looks wrong on several accounts: 1) The plane size should already have been computed when we received the buffers, 2) With this code each plane is assigned the same size, which is obviously wrong with formats such as NV12, 3) The size in bytes of a plane depends on the coded size, not the visible size. Looking at the git history it appears that this code has been here since the initial revision of the decoder, and then moved around. Maybe it was just here to make things work in the beginning and slipped under the radar. In any case, removing that code does not seem to hurt. BUG=b:161774071 BUG=b:169295147 TEST=Android Youtube plays properly on Hatch. Change-Id: I6c8949c49c070daaa3540b757dd35469b571c43c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3026344 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> |
||
---|---|---|
.. | ||
src | ||
.build_test_serial | ||
Cargo.toml |