mirrors/jj
1
0
Fork 1
mirror of https://github.com/martinvonz/jj.git synced 2024-12-28 23:55:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

git: update exported_view after updating in Git repo

Browse source 
When skipping branches we fail to update in the backing Git repo, we
must also skip updating the `exported_view` object, so we don't trick
ourselves into thinking the branch was already updated in the Git repo
on the next export.
This commit is contained in:
Martin von Zweigbergk 2022-11-24 10:30:33 -08:00 committed by Martin von Zweigbergk
parent a09763f340
commit 0dbbd4266f
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lib/src/git.rs
View file

@ -186,7 +186,6 @@ fn export_changes(
let new_view = mut_repo.view();
let old_branches: HashSet<_> = old_view.branches().keys().cloned().collect();
let new_branches: HashSet<_> = new_view.branches().keys().cloned().collect();
let mut exported_view = old_view.store_view().clone();
let mut branches_to_update = BTreeMap::new();
let mut branches_to_delete = BTreeSet::new();
// First find the changes we want need to make without modifying mut_repo
@ -199,13 +198,6 @@ fn export_changes(
if let Some(new_branch) = new_branch {
match new_branch {
RefTarget::Normal(id) => {
exported_view.branches.insert(
branch_name.clone(),
BranchTarget {
local_target: Some(RefTarget::Normal(id.clone())),
remote_targets: Default::default(),
},
);
branches_to_update
.insert(branch_name.clone(), Oid::from_bytes(id.as_bytes()).unwrap());
}
@ -215,7 +207,6 @@ fn export_changes(
}
}
} else {
exported_view.branches.remove(branch_name);
branches_to_delete.insert(branch_name.clone());
}
}
@ -236,9 +227,19 @@ fn export_changes(
}
}
}
let mut exported_view = old_view.store_view().clone();
for (branch_name, new_target) in branches_to_update {
let git_ref_name = format!("refs/heads/{}", branch_name);
git_repo.reference(&git_ref_name, new_target, true, "export from jj")?;
exported_view.branches.insert(
branch_name.clone(),
BranchTarget {
local_target: Some(RefTarget::Normal(CommitId::from_bytes(
new_target.as_bytes(),
))),
remote_targets: Default::default(),
},
);
mut_repo.set_git_ref(
git_ref_name,
RefTarget::Normal(CommitId::from_bytes(new_target.as_bytes())),
@ -249,6 +250,7 @@ fn export_changes(
if let Ok(mut git_ref) = git_repo.find_reference(&git_ref_name) {
git_ref.delete()?;
}
exported_view.branches.remove(&branch_name);
mut_repo.remove_git_ref(&git_ref_name);
}
Ok(exported_view)