From 209c62075ec6afdfc6eca86af21b2dd27fe773d8 Mon Sep 17 00:00:00 2001 From: Martin von Zweigbergk Date: Thu, 15 Apr 2021 06:51:06 -0700 Subject: [PATCH] cli: disallow pushing open commit --- src/commands.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/commands.rs b/src/commands.rs index 78e4e27b0..8055411d6 100644 --- a/src/commands.rs +++ b/src/commands.rs @@ -2118,6 +2118,11 @@ fn cmd_git_push( let repo = get_repo(ui, &matches)?; let git_repo = get_git_repo(repo.store())?; let (repo, commit) = resolve_revision_arg(ui, repo, cmd_matches)?; + if commit.is_open() { + return Err(CommandError::UserError( + "Won't push open commit".to_string(), + )); + } let remote_name = cmd_matches.value_of("remote").unwrap(); let branch_name = cmd_matches.value_of("branch").unwrap(); git::push_commit(&git_repo, &commit, remote_name, branch_name)