From 39bdd5eb3fcc1a21552c83c2689a2495e597262f Mon Sep 17 00:00:00 2001 From: Samuel Tardieu Date: Thu, 2 Jan 2025 22:36:21 +0100 Subject: [PATCH] perf: use `.next_back()` to get the last component Using `.last()` needs to go through all components first instead of splitting only the last one. --- cli/src/merge_tools/external.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/src/merge_tools/external.rs b/cli/src/merge_tools/external.rs index 303bfc75b..2b50fccc8 100644 --- a/cli/src/merge_tools/external.rs +++ b/cli/src/merge_tools/external.rs @@ -212,7 +212,7 @@ pub fn run_mergetool_external( }; let temp_dir = new_utf8_temp_dir("jj-resolve-").map_err(ExternalToolError::SetUpDir)?; - let suffix = if let Some(filename) = repo_path.components().last() { + let suffix = if let Some(filename) = repo_path.components().next_back() { let name = filename .to_fs_name() .map_err(|err| err.with_path(repo_path))?;