From 3e23155b102adcffd54c7f5288b9a66b74573357 Mon Sep 17 00:00:00 2001 From: Austin Seipp Date: Tue, 11 Jul 2023 22:14:07 -0500 Subject: [PATCH] fix(github): run 'nix build' as part of CI, too Summary: While I was developing #1846, I found a case where `nix flake check` succeeded but `nix build` on the jujutsu expression failed, which was confusing to me. If it had been merged, it would have broke the ability to use Nix to install things. Let's try to attack this, and punch a parallel job into the build matrix; hopefully running the two jobs concurrently can help catch this without making build time much worse. Signed-off-by: Austin Seipp Change-Id: If2520d69492fa6abe499c1cb1d51d6e1 --- .github/workflows/nix-linux.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nix-linux.yml b/.github/workflows/nix-linux.yml index bcac9321f..22fdcd1ee 100644 --- a/.github/workflows/nix-linux.yml +++ b/.github/workflows/nix-linux.yml @@ -10,7 +10,12 @@ permissions: read-all jobs: nix: - runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + os: [ ubuntu-latest ] + mode: [ "flake check", "build" ] + runs-on: ${{ matrix.os }} name: nix-build timeout-minutes: 20 steps: @@ -21,4 +26,4 @@ jobs: with: extra_nix_config: | experimental-features = nix-command flakes - - run: nix flake check --print-build-logs --show-trace + - run: nix ${{ matrix.mode }} --print-build-logs --show-trace