mirrors/jj
1
0
Fork 1
mirror of https://github.com/martinvonz/jj.git synced 2025-01-27 14:47:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fileset: box FunctionCallNode to make enum smaller

Browse source 
For the same reason as the previous commit.
This commit is contained in:
Yuya Nishihara 2024-05-16 22:52:57 +09:00
parent e87b49ccc1
commit 3e51e93265
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/src/fileset_parser.rs
View file

@ -184,7 +184,7 @@ pub enum ExpressionKind<'i> {
StringPattern { kind: &'i str, value: String },
Unary(UnaryOp, Box<ExpressionNode<'i>>),
Binary(BinaryOp, Box<ExpressionNode<'i>>, Box<ExpressionNode<'i>>),
FunctionCall(FunctionCallNode<'i>),
FunctionCall(Box<FunctionCallNode<'i>>),
}
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq)]
@ -251,7 +251,7 @@ fn parse_primary_node(pair: Pair<Rule>) -> FilesetParseResult<ExpressionNode> {
let expr = match first.as_rule() {
Rule::expression => return parse_expression_node(first),
Rule::function => {
let function = parse_function_call_node(first)?;
let function = Box::new(parse_function_call_node(first)?);
ExpressionKind::FunctionCall(function)
}
Rule::string_pattern => {
@ -412,7 +412,8 @@ mod tests {
ExpressionKind::Binary(op, lhs, rhs)
}
ExpressionKind::FunctionCall(function) => {
ExpressionKind::FunctionCall(normalize_function_call(function))
let function = Box::new(normalize_function_call(*function));
ExpressionKind::FunctionCall(function)
}
};
ExpressionNode {