commit: simplify parents() and predecessors() impl

This commit is contained in:
Yuya Nishihara 2022-09-22 17:44:41 +09:00
parent c94f54689d
commit 48a7378d9f

View file

@ -80,11 +80,11 @@ impl Commit {
} }
pub fn parents(&self) -> Vec<Commit> { pub fn parents(&self) -> Vec<Commit> {
let mut parents = Vec::new(); self.data
for parent in &self.data.parents { .parents
parents.push(self.store.get_commit(parent).unwrap()); .iter()
} .map(|id| self.store.get_commit(id).unwrap())
parents .collect()
} }
pub fn predecessor_ids(&self) -> &[CommitId] { pub fn predecessor_ids(&self) -> &[CommitId] {
@ -92,11 +92,11 @@ impl Commit {
} }
pub fn predecessors(&self) -> Vec<Commit> { pub fn predecessors(&self) -> Vec<Commit> {
let mut predecessors = Vec::new(); self.data
for predecessor in &self.data.predecessors { .predecessors
predecessors.push(self.store.get_commit(predecessor).unwrap()); .iter()
} .map(|id| self.store.get_commit(id).unwrap())
predecessors .collect()
} }
pub fn tree(&self) -> Tree { pub fn tree(&self) -> Tree {