From 881d75e899b5bf991e97a3065bfe3870d4ed8ce9 Mon Sep 17 00:00:00 2001 From: Martin von Zweigbergk Date: Sat, 27 Jan 2024 08:44:42 -0800 Subject: [PATCH] rewrite: drop TODO about changing the API The `rebase_next()` method is private, so I think we've addressed the TODO. --- lib/src/rewrite.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/src/rewrite.rs b/lib/src/rewrite.rs index b640afb3a..d48bc8a42 100644 --- a/lib/src/rewrite.rs +++ b/lib/src/rewrite.rs @@ -539,8 +539,6 @@ impl<'settings, 'repo> DescendantRebaser<'settings, 'repo> { Ok(()) } - // TODO: Perhaps change the interface since it's not just about rebasing - // commits. fn rebase_next(&mut self) -> Result, TreeMergeError> { while let Some(old_commit) = self.to_visit.pop() { let old_commit_id = old_commit.id().clone(); @@ -616,7 +614,6 @@ impl<'settings, 'repo> DescendantRebaser<'settings, 'repo> { pub fn rebase_all(&mut self) -> Result<(), TreeMergeError> { while self.rebase_next()?.is_some() {} - // TODO: As the TODO above says, we should probably change the API. let mut view = self.mut_repo.view().store_view().clone(); for commit_id in &self.heads_to_remove { view.head_ids.remove(commit_id);