mirrors/jj
1
0
Fork 1
mirror of https://github.com/martinvonz/jj.git synced 2024-10-23 06:57:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

cli: Provide better flags for the "less" pager than default

Browse source
This commit is contained in:
Benjamin Brittain 2024-02-03 11:46:32 -05:00
parent ae3404cdf2
commit cb23225865
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
cli/src/config.rs
View file

@ -324,7 +324,16 @@ fn env_base() -> config::Config {
builder = builder.set_override("ui.color", "never").unwrap();
}
if let Ok(value) = env::var("PAGER") {
builder = builder.set_override("ui.pager", value).unwrap();
// If 'less' is the value of PAGER, do not override the pager.
// Many systems ship with "R" as the only setting in $LESS, which provides
// a less than ideal experience for 'less' with jj, since they won't see the
// log history persist on the screen. While slightly inconsistent to ignore
// that setting, it should provide a better "out-of-box experience". If a user
// truly wants to change the values that are passed to "less", they can set that
// in the ui.pager jj config.
if value != "less" {
builder = builder.set_override("ui.pager", value).unwrap();
}
}
if let Ok(value) = env::var("VISUAL") {
builder = builder.set_override("ui.editor", value).unwrap();