mirrors/jj
1
0
Fork 1
mirror of https://github.com/martinvonz/jj.git synced 2024-12-31 16:40:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

git: avoid creating a HashSet only to convert to a Vec

Browse source
This commit is contained in:
Martin von Zweigbergk 2022-04-28 20:55:02 -07:00 committed by Martin von Zweigbergk
parent 8ef00a3498
commit dc32bb1f95
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/src/git.rs
View file

@ -58,10 +58,10 @@ pub fn import_refs(
) -> Result<(), GitImportError> {
let store = mut_repo.store().clone();
let mut existing_git_refs = mut_repo.view().git_refs().clone();
let old_git_heads: HashSet<_> = existing_git_refs
let old_git_heads = existing_git_refs
.values()
.flat_map(|old_target| old_target.adds())
.collect();
.collect_vec();
let mut new_git_heads = HashSet::new();
let mut changed_git_refs = BTreeMap::new();
let git_refs = git_repo.references()?;
@ -122,7 +122,6 @@ pub fn import_refs(
// Find commits that are no longer referenced in the git repo and abandon them
// in jj as well.
let old_git_heads = old_git_heads.into_iter().collect_vec();
let new_git_heads = new_git_heads.into_iter().collect_vec();
// We could use mut_repo.record_rewrites() here but we know we only need to care
// about abandoned commits for now. We may want to change this if we ever