mirrors/jj
1
0
Fork 1
mirror of https://github.com/martinvonz/jj.git synced 2025-01-05 20:55:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

index: use u32::from_le_bytes() to reinterpret bytes as integer

Browse source 
It's less abstract than going through io::Read, so is probably easier for
compiler to optimize out. I also feel it's a bit more readable.
This commit is contained in:
Yuya Nishihara 2023-12-18 17:31:06 +09:00
parent 889f052dfa
commit fb06e89649
1 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
lib/src/default_index/readonly.rs
View file

@ -87,19 +87,19 @@ impl CommitGraphEntry<'_> {
}
fn generation_number(&self) -> u32 {
(&self.data[4..]).read_u32::<LittleEndian>().unwrap()
u32::from_le_bytes(self.data[4..8].try_into().unwrap())
}
fn num_parents(&self) -> u32 {
(&self.data[8..]).read_u32::<LittleEndian>().unwrap()
u32::from_le_bytes(self.data[8..12].try_into().unwrap())
}
fn parent1_pos(&self) -> IndexPosition {
IndexPosition((&self.data[12..]).read_u32::<LittleEndian>().unwrap())
IndexPosition(u32::from_le_bytes(self.data[12..16].try_into().unwrap()))
}
fn parent2_overflow_pos(&self) -> u32 {
(&self.data[16..]).read_u32::<LittleEndian>().unwrap()
u32::from_le_bytes(self.data[16..20].try_into().unwrap())
}
// TODO: Consider storing the change ids in a separate table. That table could
@ -137,11 +137,8 @@ impl CommitLookupEntry<'_> {
}
fn pos(&self) -> IndexPosition {
IndexPosition(
(&self.data[self.commit_id_length..][..4])
.read_u32::<LittleEndian>()
.unwrap(),
)
let pos = u32::from_le_bytes(self.data[self.commit_id_length..][..4].try_into().unwrap());
IndexPosition(pos)
}
}
@ -328,11 +325,8 @@ impl ReadonlyIndexSegment {
let offset = (overflow_pos as usize) * 4
+ (self.num_local_commits as usize) * self.commit_graph_entry_size
+ (self.num_local_commits as usize) * self.commit_lookup_entry_size;
IndexPosition(
(&self.data[offset..][..4])
.read_u32::<LittleEndian>()
.unwrap(),
)
let pos = u32::from_le_bytes(self.data[offset..][..4].try_into().unwrap());
IndexPosition(pos)
}
fn commit_id_byte_prefix_to_lookup_pos(&self, prefix: &CommitId) -> Option<u32> {