mirrors/jj
1
0
Fork 1
mirror of https://github.com/martinvonz/jj.git synced 2025-02-08 21:48:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

tests: don't leave /tmp/file, use tempfile::TempDir for cleanup

Browse source
This commit is contained in:
Yuya Nishihara 2022-08-16 20:35:27 +09:00
parent 6238f9b369
commit fbcec1fd2c
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/src/file_util.rs
View file

@ -37,8 +37,6 @@ pub fn persist_content_addressed_temp_file<P: AsRef<Path>>(
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use std::env::temp_dir;
use std::io::Write; use std::io::Write;
use test_case::test_case; use test_case::test_case;
@ -47,8 +45,8 @@ mod tests {
#[test] #[test]
fn test_persist_no_existing_file() { fn test_persist_no_existing_file() {
let temp_dir = temp_dir(); let temp_dir = tempfile::tempdir().unwrap();
let target = temp_dir.join("file"); let target = temp_dir.path().join("file");
let mut temp_file = NamedTempFile::new_in(&temp_dir).unwrap(); let mut temp_file = NamedTempFile::new_in(&temp_dir).unwrap();
temp_file.write_all(b"contents").unwrap(); temp_file.write_all(b"contents").unwrap();
assert!(persist_content_addressed_temp_file(temp_file, &target).is_ok()); assert!(persist_content_addressed_temp_file(temp_file, &target).is_ok());
@ -57,8 +55,8 @@ mod tests {
#[test_case(false ; "existing file open")] #[test_case(false ; "existing file open")]
#[test_case(true ; "existing file closed")] #[test_case(true ; "existing file closed")]
fn test_persist_target_exists(existing_file_closed: bool) { fn test_persist_target_exists(existing_file_closed: bool) {
let temp_dir = temp_dir(); let temp_dir = tempfile::tempdir().unwrap();
let target = temp_dir.join("file"); let target = temp_dir.path().join("file");
let mut temp_file = NamedTempFile::new_in(&temp_dir).unwrap(); let mut temp_file = NamedTempFile::new_in(&temp_dir).unwrap();
temp_file.write_all(b"contents").unwrap(); temp_file.write_all(b"contents").unwrap();