3301 commits

Author	SHA1	Message	Date
Yuya Nishihara	8249e9fee8	annotate: inline get_initial_commit_line_map() ... It no longer makes sense to initialize Source line_map and build HashMap<Commit, Source> in one function. Let's extract the line_map initialization to a function instead.	2024-10-28 12:40:01 +09:00
Yuya Nishihara	84cc6e2c2f	annotate: merge file line map and content cache into a single HashMap ... Their lifetimes are identical. We can remove .unwrap()s that were needed in order to re-borrow cached contents after loading.	2024-10-28 12:40:01 +09:00
Yuya Nishihara	b485881d50	tests: add basic tests for annotation function	2024-10-27 22:51:54 +09:00
Yuya Nishihara	f6db2426e8	annotate: impl Debug on AnnotateResults type, use BString for readability ... I'm going to add snapshot tests. Debug isn't strictly needed, but it should help printf debugging.	2024-10-27 22:51:54 +09:00
Yuya Nishihara	8c0ab6af7a	local_working_copy: import std::io for short	2024-10-23 23:51:21 +09:00
Yuya Nishihara	4187847c60	revset: propagate errors from filter predicates ... All intermediate nodes are changed to RevWalk of Result<IndexPosition, _> type to pass BackendError around from filter predicates. Leaf ancestors/descendants computation is unchanged, and mapped to Result at revset_engine layer. This is simpler than converting all RevWalk impls to Result<_, _>.	2024-10-23 09:30:51 +09:00
Yuya Nishihara	e37378dc18	revset: implement RevWalk::map() and filter_map(), remove filter() ... We'll need to propagate error from predicate function, so .filter() will no longer be usable. .map() will be used in order to wrap infallible ancestry lookup with Ok(_). Some RevsetImpl methods are migrated to .map() as example.	2024-10-23 09:30:51 +09:00
Yuya Nishihara	ad676cdf7e	revset: collect RevWalkBuilder arguments by caller ... This will make error propagation simpler in the following patches. The input iterators will be changed to Item = Result<IndexPosition, _>.	2024-10-23 09:30:51 +09:00
Yuya Nishihara	e6e5c7412c	revset_graph: use VecDeque for look ahead buffer ... I don't see measurable performance difference, but VecDeque is theoretically simpler than BTreeSet. The input is sorted, so we never do random insertion.	2024-10-23 09:30:51 +09:00
Yuya Nishihara	a38e59f447	revset: fix is_empty() doc, the logic was inverted	2024-10-23 09:30:51 +09:00
Benjamin Tan	0a38fdc9d3	rewrite: move_commits: add MoveCommitsTarget enum to specify roots or commits to move ... This also allows some minor optimizations to be performed, such as avoiding recomputation of the connected target set when `MoveCommitsTarget::Roots` is used since the connected target set is identical to the target set (all descendants of the roots).	2024-10-22 20:39:50 +08:00
Benjamin Tan	95b7a60979	rewrite: extract compute_internal_parents_within function	2024-10-22 20:39:50 +08:00
Benjamin Tan	9927a9856e	rewrite: make MoveCommitStats derive Default	2024-10-22 20:39:50 +08:00
Yuya Nishihara	a493913000	revset: propagate evaluation errors from other Revset methods ... is_empty() could also return Result<bool, _>, but I think the current definition is also good. If an error occurred, revset.iter() would return at least one item, so it's not empty.	2024-10-22 09:03:53 +09:00
Yuya Nishihara	825b6670b3	revset: move containing_fn() type alias to lib ... If the return type were changed to Result<bool, _>, clippy would complain about the type complexity.	2024-10-22 09:03:53 +09:00
Yuya Nishihara	ac08f995d8	graph: add GraphNode<N> type alias instead of Graph/NextNodeResult<N, E> ... It can be used in more places, and the resulting types are short enough to silence clippy.	2024-10-22 09:03:53 +09:00
Martin von Zweigbergk	9d4a97381f	rewrite: don't resolve intermediate parent tree when rebasing ... Let's say we're updating one parent of a merge: ``` E E' /|\ /|\ B C D -> B C D' \|/ \|/ A A ``` When rebasing `E` to create `E'` there, we do that by merging the changes compared to the auto-merged parents. The auto-merged parents before is `B+(C-A)+(D-A)`, and after it's `B+(C-A)+(D'-A)`. Then we rebase the diff, which gives us `E' = B+(C-A)+(D'-A) + (E - (B+(C-A)+(D-A))) = D' + (E - D')`. However, we currently don't do quite that simplification because we first resolve conflicts when possible in the two auto-merged parent trees (before and after). That rarely makes a difference to the result, but it's wasteful to do it. It does make a difference in some cases where our merge algorithm is lossy, which currently is only the "A+(A-B)=A" case. I added a test case showing where it does make a difference. It's a non-obvious cases but I think the new behavior is more correct (the old behavior was a conflict).	2024-10-21 10:58:47 -07:00
Yuya Nishihara	3d31928dac	revset: drop support for HEAD@git symbol resolution ... This was added at f5f61f6bfe "revset: resolve 'HEAD@git' just like other pseudo @git branches." As I said in this patch, there was no practical use case of the HEAD@git symbol. Suppose we implement colocated workspaces/worktrees #4436, there may be multiple Git HEAD revisions. This means HEAD can no longer be abstracted as a symbol of the "git" remote.	2024-10-21 09:21:34 +09:00
Yuya Nishihara	2413fffcf9	revset: extract helper that parses function call ... I'm going to add keyword arguments support to templater.	2024-10-21 08:47:08 +09:00
dploch	49e9003c4e	revset: allow iterators to return evaluation errors ... Custom backends may rely on networking or other unreliable implementations to support revsets, this change allows them to return errors cleanly instead of panicking. For simplicity, only the public-facing Revset and RevsetGraph types are changed in this commit; the internal revset engine remains mostly unchanged and error-free since it cannot generally produce errors.	2024-10-18 17:09:35 -04:00
dploch	c970181ae2	revset: change the commits() iterator to return RevsetEvaluationError ... This facilatates a change to the Revset trait in the next commit.	2024-10-18 17:09:35 -04:00
dploch	9e3e7cc38b	revset: allow RevsetEvaluationError to store arbitrary sources	2024-10-18 17:09:35 -04:00
Samuel Tardieu	2112584973	style: remove unneeded lifetimes from trait implementations ... Clippy 1.83 (currently in beta) detects more cases of unneeded lifetimes, namely in trait implementation declarations. Since this lint is warn by default, we need to fix those instances to get a clean CI.	2024-10-17 13:35:06 +02:00
Samuel Tardieu	33f9b89350	rewrite: build Vec instances directly ... `[].to_vec()` looks like a manual implementation of `vec![]`.	2024-10-17 00:09:05 +02:00
Benjamin Tan	ef5ed39976	rewrite: move_commits: allow specifying the roots of target set manually ... This is required when performing `rebase -s a -s b` where "b" is a descendant of "a". Both "a" and "b" should be regarded as the roots of the target set and be rebased onto the new destination.	2024-10-16 11:26:59 +08:00
Benjamin Tan	6a1262901e	rewrite: move_commits: use rebase_commit_with_options to rebase commits ... This allows for `RebaseOptions` to be respected. This will be used when migrating `rebase --source`/`rebase --branch` to use `move_commits` to respect the `--before`/`--after` options.	2024-10-16 11:26:59 +08:00
Benjamin Tan	8e817bc24b	revset: add coalesce(revsets...) ... The `coalesce` function takes a list of revsets and returns the commits in the first revset in the list which evalutes to a non-empty set of commits. It can be used to display fallbacks if a certain commit cannot be found, e.g. `coalesce(present(user_configured_trunk), builtin_trunk)`.	2024-10-16 10:36:27 +08:00
Yuya Nishihara	ad4b940daa	object_id: implement Display on ObjectId types ... It's convenient if id can be inlined in error messages.	2024-10-16 09:12:16 +09:00
Yuya Nishihara	5658f070fc	hex_util: simplify conversion from bytes to reverse hex string	2024-10-16 09:12:16 +09:00
Yuya Nishihara	59c635bfd0	object_id: add ChangeId::reverse_hex() for convenience ... Borrowed from #4470.	2024-10-16 09:12:16 +09:00
Alec Snyder	470275b0d0	cli: Add command jj file annotate ... A new module is added to jj_lib which exposes a function get_annotation_for_file. This annotates the given file line by line with commit information according to the commit that made the most recent change to the line. Similarly, a new command is added to the CLI called `jj file annotate` which accepts a file path. It then prints out line by line the commit information for the line and the line itself. Specific commit information can be configured via the templates.annotate_commit_summary config variable	2024-10-15 16:31:32 +03:00
Yuya Nishihara	a9df7a1339	fileset: remove Eq + PartialEq from FilesetExpression/Pattern ... For the same reason as the revset change 9613ec4f. If we add more complex pattern or expression, Eq might not be implementable.	2024-10-15 06:58:44 +09:00
Yuya Nishihara	d177bb9f66	fileset: switch expression tests to insta::assert_debug_snapshot()	2024-10-15 06:58:44 +09:00
Yuya Nishihara	2888c1d842	fileset: filter out glob tokens field from snapshot tests ... It will become more verbose in the next patch.	2024-10-15 06:58:44 +09:00
Lukas Wirth	9f16419202	git clone: Add depth argument	2024-10-14 20:01:08 +02:00
Lukas Wirth	802e3db27e	git_backend: Support shallow git repositories	2024-10-14 20:01:08 +02:00
Yuya Nishihara	e5e85e781f	diff: inline contents and ranges vecs up to two sides ... This appears to be a bit faster if there are tons of unchanged ranges. ``` group new old ----- --- --- bench_diff_git_git_read_tree_c 1.00 58.5±0.12µs 1.07 62.7±0.60µs bench_diff_lines/modified/10k 1.00 34.2±0.72ms 1.08 37.0±1.09ms bench_diff_lines/modified/1k 1.00 3.1±0.08ms 1.12 3.5±0.01ms bench_diff_lines/reversed/10k 1.00 28.0±0.15ms 1.01 28.4±0.51ms bench_diff_lines/reversed/1k 1.00 616.0±16.20µs 1.00 617.0±9.29µs bench_diff_lines/unchanged/10k 1.00 3.5±0.04ms 1.10 3.9±0.06ms bench_diff_lines/unchanged/1k 1.00 328.4±4.44µs 1.07 352.0±1.41µs ```	2024-10-13 21:28:39 +09:00
Vamsi Avula	a6aa25c9eb	templates: support hex bytes in string literals ... One particular use case for these is escape sequences -- and to that end, I'm also adding `\e` as a shorthand for `\x1b`. Change-Id: Id000000040ea6fd8e2d720219931485960c570dd	2024-10-13 12:02:40 +05:30
Yuya Nishihara	a9433784b0	diff: rely on compacted unchanged regions when iterating hunks ... We don't have to test emptiness of contents between unchanged regions.	2024-10-13 08:51:04 +09:00
Yuya Nishihara	e15c7a8662	diff: insert empty unchanged range at start to remove some clone()s ... This seems more consistent as we have a terminal range at the end.	2024-10-13 08:51:04 +09:00
Yuya Nishihara	1967a55b92	diff: omit insertion of terminal range that would be compacted ... This isn't important, but I'm going to add another empty range at the start, and it's easier if the modification of regions is scoped.	2024-10-13 08:51:04 +09:00
Yuya Nishihara	ff0a1ad075	diff: simplify merge of refined ranges, unimplement Ord ... The Ord implementation didn't conform to Eq (which compares "self.others" literally), and we don't need Ord to insert non-overlapping ranges before the current range.	2024-10-13 08:51:04 +09:00
Yuya Nishihara	f166fd0726	revset: add at_operation(op, expression) ... This can be used in order to refer old working-copy commit, for example. If we find it's useful, maybe we can add an infix syntax later. Closes #1283	2024-10-12 07:57:55 +09:00
Yuya Nishihara	303564ca2b	repo: add generic Repo::base_repo() to access current operation from revset ... This isn't fancy, but I couldn't find a better abstraction. Note that MutableRepo::base_repo() isn't removed as it has to return &Arc<_>, whereas <ReadonlyRepo as Repo>::base_repo() can't return &Arc<_>.	2024-10-12 07:57:55 +09:00
dploch	4f15ca41bf	squash: move the core functionality to jj_lib ... This allows 'squash' to be executed more easily from a programmatic context	2024-10-09 10:15:57 -04:00
Yuya Nishihara	09d91efea5	id_prefix: propagate error from disambiguation index ... The id.shortest() template prints a warning and falls back to repo-global resolution. This seems better than erroring out. There are a few edge cases in which the short-prefixes resolution can fail unexpectedly. For example, the trunk() revision might not exist in operations before "jj git clone".	2024-10-09 14:07:48 +09:00
Yuya Nishihara	3ff1f985f3	revset: pass separate repo to disambiguation index ... The idea is that the disambiguation index can be loaded from a repo which is different from the symbol resolution context. Suppose we add at_operation(op, expr) revset, a symbol inside at_operation() expression will have to be resolved within that operation, whereas the disambiguation index is cached globally by WorkspaceCommandHelper. We could build temporary disambiguation index for each at-op repo, but that would be complicated implementation-wise, and wouldn't be useful. For example, a query "x | at_operation(@-, x)" might be resolved to "xy | at_operation(@-, xz)" if disambiguation index were reloaded for the @- operation. Instead, the short change ID "x" can be disambiguated to "xy", then resolved to the corresponding commit IDs at each operation.	2024-10-09 14:07:48 +09:00
Yuya Nishihara	3d41237efe	id_prefix: add empty disambiguation index for convenience ... Callers might want to fall back to an empty index if context.populate() failed.	2024-10-09 14:07:48 +09:00
Yuya Nishihara	bf6620d8d9	id_prefix: add explicit method that loads disambiguation index ... This unblocks reuse of a symbol resolver instance for a different repo view specified by at_operation() revset. See later commits for details. It's also easier to handle error if there is a single function that can fail.	2024-10-09 14:07:48 +09:00
Yuya Nishihara	760134f9c1	revset: error out on unindexed commit ID instead of panicking ... It no longer makes sense to handle missing root commit by the revset frontend, but panicking wouldn't be good either. Let's make it error out.	2024-10-08 13:21:03 +09:00