mirrors/make
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/make.git synced 2025-01-27 17:49:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

* src/remake.c (update_goal_chain): [SV 64016] Avoid double negation

Browse source
This commit is contained in:
Dmitry Goncharov 2023-04-30 09:07:17 -04:00 committed by Paul Smith
parent fec72ea308
commit 5340a3d5d1
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/remake.c
View file

@ -157,7 +157,7 @@ update_goal_chain (struct goaldep *goaldeps)
{ {
/* Iterate over all double-colon entries for this file. */ /* Iterate over all double-colon entries for this file. */
struct file *file, *dchead; struct file *file, *dchead;
int stop = 0, any_not_updated = 0; int stop = 0, all_updated = 1;
g = gu->shuf ? gu->shuf : gu; g = gu->shuf ? gu->shuf : gu;
@ -253,7 +253,7 @@ update_goal_chain (struct goaldep *goaldeps)
/* Keep track if any double-colon entry is not finished. /* Keep track if any double-colon entry is not finished.
When they are all finished, the goal is finished. */ When they are all finished, the goal is finished. */
any_not_updated |= !file->updated; all_updated &= file->updated;
file->dontcare = 0; file->dontcare = 0;
@ -267,7 +267,7 @@ update_goal_chain (struct goaldep *goaldeps)
if (wait) if (wait)
break; break;
if (stop || !any_not_updated) if (stop || all_updated)
{ {
/* If we have found nothing whatever to do for the goal, /* If we have found nothing whatever to do for the goal,
print a message saying nothing needs doing. */ print a message saying nothing needs doing. */
@ -290,16 +290,13 @@ update_goal_chain (struct goaldep *goaldeps)
else else
lastgoal->next = gu->next; lastgoal->next = gu->next;
gu = lastgoal == 0 ? goals : lastgoal->next;
if (stop) if (stop)
break; break;
} }
else else
{ lastgoal = gu;
lastgoal = gu;
gu = gu->next; gu = gu->next;
}
} }
/* If we reached the end of the dependency graph update CONSIDERED /* If we reached the end of the dependency graph update CONSIDERED