mirrors/make
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/make.git synced 2025-01-28 18:10:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Inverted the boolean test from what I wanted it to be. Added a

Browse source 
regression test to make sure this continues to work.
This commit is contained in:
Paul Smith 2011-05-07 14:36:11 +00:00
parent b5c065418f
commit b664d3a91d
4 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ChangeLog
View file

@ -1,3 +1,7 @@
2011-05-07 Paul Smith <psmith@gnu.org>
* read.c (parse_file_seq): Ensure existence checks use glob().
2011-05-07 Eli Zaretskii <eliz@gnu.org>
* job.c (construct_command_argv_internal): Don't assume shellflags

2
read.c
View file

@ -3111,7 +3111,7 @@ parse_file_seq (char **stringp, unsigned int size, int stopchar,
#endif /* !NO_ARCHIVES */
/* glob() is expensive: don't call it unless we need to. */
if (!(flags & PARSEFS_EXISTS) || strpbrk (name, "?*[") == NULL)
if (!(flags & PARSEFS_EXISTS) && strpbrk (name, "?*[") == NULL)
{
globme = 0;
i = 1;

5
tests/ChangeLog
View file

@ -1,3 +1,8 @@
2011-05-07 Paul Smith <psmith@gnu.org>
* scripts/functions/wildcard: Verify wildcard used to test for
file existence/non-existence.
2011-05-02 Paul Smith <psmith@gnu.org>
* scripts/functions/sort: Add a test for Savannah bug #33125.

12
tests/scripts/functions/wildcard
View file

@ -88,4 +88,16 @@ all: ; @echo $(wildcard xz--y*.7)
!,
'', "\n");
# TEST #5: wildcard used to verify file existence
touch('xxx.yyy');
run_make_test(q!exists: ; @echo file=$(wildcard xxx.yyy)!,
'', "file=xxx.yyy\n");
unlink('xxx.yyy');
run_make_test(q!exists: ; @echo file=$(wildcard xxx.yyy)!,
'', "file=\n");
1;