mirror of
https://git.savannah.gnu.org/git/make.git
synced 2025-01-12 16:45:35 +00:00
98da874c43
Export all variables, including exported makefile variables, when invoking a shell for the $(shell ...) function. If we detect a recursive variable expansion, silently ignore that variable and do not export it. We do print a debug message. * NEWS: Announce the potential backward-incompatibility. * doc/make.texi (Shell Function): Document the export behavior. * src/main.c (main): Add "shell-export" to .FEATURES. * src/job.h: New function to free struct childbase. * src/job.c (free_childbase): Implement it; call from free_child. * src/function.c (func_shell_base): Use target_environment() to obtain the proper environment for the shell function. Use free_childbase() to free memory. (windows32_openpipe): Don't reset the environment: the caller already provided a proper PATH variable in envp. * src/variable.c (target_environment): If we detect a recursive expansion and we're called from func_shell, ignore the variable. (sync_Path_environment): Simplify and reduce memory allocation. * tests/scripts/functions/shell: Add tests for this.
145 lines
3.2 KiB
Perl
145 lines
3.2 KiB
Perl
# -*-perl-*-
|
|
|
|
$description = 'Test the $(shell ...) function.';
|
|
|
|
$details = '';
|
|
|
|
# Test standard shell
|
|
run_make_test('.PHONY: all
|
|
OUT := $(shell echo hi)
|
|
all: ; @echo $(OUT)
|
|
','','hi');
|
|
|
|
# Test shells inside rules.
|
|
run_make_test('.PHONY: all
|
|
all: ; @echo $(shell echo hi)
|
|
','','hi');
|
|
|
|
# Verify .SHELLSTATUS
|
|
run_make_test('.PHONY: all
|
|
PRE := $(.SHELLSTATUS)
|
|
$(shell exit 0)
|
|
OK := $(.SHELLSTATUS)
|
|
$(shell exit 1)
|
|
BAD := $(.SHELLSTATUS)
|
|
all: ; @echo PRE=$(PRE) OK=$(OK) BAD=$(BAD)
|
|
','','PRE= OK=0 BAD=1');
|
|
|
|
# Test unescaped comment characters in shells. Savannah bug #20513
|
|
run_make_test(q!
|
|
FOO := $(shell echo '#')
|
|
foo: ; echo '$(FOO)'
|
|
!,
|
|
'', "echo '#'\n#\n");
|
|
|
|
# Test that exported variables are passed to $(shell ...)
|
|
$ENV{FOO} = 'baz';
|
|
run_make_test(q!
|
|
OUT = $(shell echo $$FOO)
|
|
foo: ; @echo '$(OUT)'
|
|
!,
|
|
'', 'baz');
|
|
|
|
$ENV{FOO} = 'baz';
|
|
run_make_test(q!
|
|
FOO = bar
|
|
OUT = $(shell echo $$FOO)
|
|
foo: ; @echo '$(OUT)'
|
|
!,
|
|
'', 'bar');
|
|
|
|
run_make_test(q!
|
|
export FOO = bar
|
|
OUT = $(shell echo $$FOO)
|
|
foo: ; @echo '$(OUT)'
|
|
!,
|
|
'', 'bar');
|
|
|
|
# Test shells inside exported environment variables, simply expanded.
|
|
run_make_test('
|
|
export HI := $(shell echo hi)
|
|
.PHONY: all
|
|
all: ; @echo $$HI
|
|
',
|
|
'','hi');
|
|
|
|
# Test shells inside exported environment variables. See SV 10593
|
|
run_make_test('
|
|
export HI = $(shell echo hi)
|
|
.PHONY: all
|
|
all: ; @echo $$HI
|
|
',
|
|
'',"hi");
|
|
|
|
$ENV{HI} = 'foo';
|
|
run_make_test('
|
|
HI = $(shell echo hi)
|
|
.PHONY: all
|
|
all: ; @echo $$HI
|
|
',
|
|
'',"hi");
|
|
|
|
$ENV{HI} = 'foo';
|
|
run_make_test('
|
|
HI = $(shell echo hi)
|
|
bad := $(HI)
|
|
.PHONY: all
|
|
all: ; @echo $$HI $(bad)
|
|
',
|
|
'',"hi hi");
|
|
|
|
if ($port_type ne 'W32') {
|
|
# Test shell errors in recipes including offset
|
|
# This needs to be ported to Windows, or else Windows error messages
|
|
# need to converted to look like more normal make errors.
|
|
run_make_test('
|
|
.RECIPEPREFIX = >
|
|
all:
|
|
>@echo hi
|
|
>$(shell ./basdfdfsed there)
|
|
>@echo $(.SHELLSTATUS)
|
|
',
|
|
'', "#MAKE#: ./basdfdfsed: $ERR_no_such_file\nhi\n127\n");
|
|
|
|
run_make_test('
|
|
$(shell ./basdfdfsed where)
|
|
all: ; @echo $(.SHELLSTATUS)
|
|
',
|
|
'', "#MAKE#: ./basdfdfsed: $ERR_no_such_file\n127\n");
|
|
|
|
# Test SHELLSTATUS for kill.
|
|
# This test could be ported to Windows, using taskkill ... ?
|
|
|
|
# Figure out the exit code for SIGINT
|
|
my $pid = fork();
|
|
if (! $pid) {
|
|
exec('kill -2 $$') or die "exec: Cannot execute sleep\n";
|
|
}
|
|
waitpid($pid, 0);
|
|
# .SHELLSTATUS for a signal gives 128 + the signal number
|
|
my $ret = $?;
|
|
if ($ret > 255) {
|
|
# Solaris 10 perl 5.8.4 puts signal number + 128 into the high 8 bits.
|
|
$ret >>= 8;
|
|
}
|
|
$ret |= 128;
|
|
|
|
run_make_test('.PHONY: all
|
|
$(shell kill -2 $$$$)
|
|
STAT := $(.SHELLSTATUS)
|
|
all: ; @echo STAT=$(STAT)
|
|
','',"STAT=$ret\n");
|
|
|
|
# Test that not-found errors can be redirected
|
|
if ($ERR_command_not_found) {
|
|
$_ = $ERR_command_not_found;
|
|
s/#CMDNAME#/bad-command/g;
|
|
run_make_test(q!
|
|
out := $(shell bad-command 2>&1)
|
|
all: ; @echo '$(.SHELLSTATUS): $(out)'
|
|
!,
|
|
'', "127: $_\n");
|
|
}
|
|
}
|
|
|
|
1;
|