mirrors/salsa
1
0
Fork 0
mirror of https://github.com/salsa-rs/salsa.git synced 2025-01-13 00:40:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #419 from kmicklas/mixed-cycle-fallback-docs

Browse source 
Remove inaccurate note about mixed cycles failing to recover
This commit is contained in:
Niko Matsakis 2024-04-24 14:26:41 +00:00 committed by GitHub
commit 05b4e3ebdc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
book/src/cycles/fallback.md
View file

@ -13,10 +13,6 @@ fn my_recover_fn(
) -> MyResultValue
```
The `db` and `cycle` argument can be used to prepare a useful error message for your users.
The `db` and `cycle` argument can be used to prepare a useful error message for your users.
**Important:** Although the recovery function is given a `db` handle, you should be careful to avoid creating a cycle from within recovery or invoking queries that may be participating in the current cycle. Attempting to do so can result in inconsistent results.
## Figuring out why recovery did not work
If a cycle occurs and *some* of the participant queries have `#[salsa::cycle]` annotations and others do not, then the query will be treated as irrecoverable and will simply panic. You can use the `Cycle::unexpected_participants` method to figure out why recovery did not succeed and add the appropriate `#[salsa::cycle]` annotations.