From 8affc724c9e169183c155e484670e2ed0d21e219 Mon Sep 17 00:00:00 2001 From: Niko Matsakis Date: Thu, 17 Jan 2019 05:21:34 -0500 Subject: [PATCH 1/2] make the compile-fail test work --- Cargo.toml | 2 ++ components/salsa_macros/src/lib.rs | 10 ++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index eb8cc4c5..1a3ca87f 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -22,3 +22,5 @@ salsa_macros = { version = "0.9", path = "components/salsa_macros" } diff = "0.1.0" env_logger = "0.5.13" rand = "0.5.5" + +[workspace] \ No newline at end of file diff --git a/components/salsa_macros/src/lib.rs b/components/salsa_macros/src/lib.rs index c660e3dc..78d31099 100644 --- a/components/salsa_macros/src/lib.rs +++ b/components/salsa_macros/src/lib.rs @@ -34,13 +34,13 @@ use syn::{parse_macro_input, AttributeArgs, FnArg, Ident, ItemTrait, ReturnType, /// ```ignore /// #[salsa::query_group] /// trait TypeckDatabase { -/// #[salsa::XXX] // see below for legal attributes +/// #[salsa::input] // see below for other legal attributes /// fn my_query(&self, input: u32) -> u64; /// /// /// Queries can have any number of inputs (including zero); if there /// /// is not exactly one input, then the key type will be /// /// a tuple of the input types, so in this case `(u32, f32)`. -/// fn other_query(input1: u32, input2: f32) -> u64; +/// fn other_query(&self, input1: u32, input2: f32) -> u64; /// } /// ``` /// @@ -100,7 +100,8 @@ use syn::{parse_macro_input, AttributeArgs, FnArg, Ident, ItemTrait, ReturnType, /// Some attributes are mutually exclusive. For example, it is an error to add /// multiple storage specifiers: /// -/// ```ignore +/// ```compile_fail +/// # use salsa_macros as salsa; /// #[salsa::query_group] /// trait CodegenDatabase { /// #[salsa::input] @@ -111,7 +112,8 @@ use syn::{parse_macro_input, AttributeArgs, FnArg, Ident, ItemTrait, ReturnType, /// /// It is also an error to annotate a function to `invoke` on an `input` query: /// -/// ```compile-fail +/// ```compile_fail +/// # use salsa_macros as salsa; /// #[salsa::query_group] /// trait CodegenDatabase { /// #[salsa::input] From 85a637eb4f16ad1b186a86225e5a3ca403e28e11 Mon Sep 17 00:00:00 2001 From: Niko Matsakis Date: Thu, 17 Jan 2019 05:28:10 -0500 Subject: [PATCH 2/2] rename `salsa_macros` to `salsa-macros` --- Cargo.toml | 2 +- components/{salsa_macros => salsa-macros}/Cargo.toml | 2 +- components/{salsa_macros => salsa-macros}/LICENSE-APACHE | 0 components/{salsa_macros => salsa-macros}/LICENSE-MIT | 0 components/{salsa_macros => salsa-macros}/README.md | 0 components/{salsa_macros => salsa-macros}/src/lib.rs | 0 6 files changed, 2 insertions(+), 2 deletions(-) rename components/{salsa_macros => salsa-macros}/Cargo.toml (94%) rename components/{salsa_macros => salsa-macros}/LICENSE-APACHE (100%) rename components/{salsa_macros => salsa-macros}/LICENSE-MIT (100%) rename components/{salsa_macros => salsa-macros}/README.md (100%) rename components/{salsa_macros => salsa-macros}/src/lib.rs (100%) diff --git a/Cargo.toml b/Cargo.toml index 1a3ca87f..8924668a 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -16,7 +16,7 @@ lock_api = "0.1.4" indexmap = "1.0.1" log = "0.4.5" smallvec = "0.6.5" -salsa_macros = { version = "0.9", path = "components/salsa_macros" } +salsa-macros = { version = "0.9", path = "components/salsa-macros" } [dev-dependencies] diff = "0.1.0" diff --git a/components/salsa_macros/Cargo.toml b/components/salsa-macros/Cargo.toml similarity index 94% rename from components/salsa_macros/Cargo.toml rename to components/salsa-macros/Cargo.toml index 8879d648..51b0350e 100644 --- a/components/salsa_macros/Cargo.toml +++ b/components/salsa-macros/Cargo.toml @@ -1,5 +1,5 @@ [package] -name = "salsa_macros" +name = "salsa-macros" version = "0.9.1" authors = ["Niko Matsakis "] edition = "2018" diff --git a/components/salsa_macros/LICENSE-APACHE b/components/salsa-macros/LICENSE-APACHE similarity index 100% rename from components/salsa_macros/LICENSE-APACHE rename to components/salsa-macros/LICENSE-APACHE diff --git a/components/salsa_macros/LICENSE-MIT b/components/salsa-macros/LICENSE-MIT similarity index 100% rename from components/salsa_macros/LICENSE-MIT rename to components/salsa-macros/LICENSE-MIT diff --git a/components/salsa_macros/README.md b/components/salsa-macros/README.md similarity index 100% rename from components/salsa_macros/README.md rename to components/salsa-macros/README.md diff --git a/components/salsa_macros/src/lib.rs b/components/salsa-macros/src/lib.rs similarity index 100% rename from components/salsa_macros/src/lib.rs rename to components/salsa-macros/src/lib.rs