Merge #372

372: run `cargo test -p salsa-2022-tests` in CI r=nikomatsakis a=XFFXFF

* run `cargo test -p salsa-2022-tests` in CI
* check format first

Co-authored-by: XFFXFF <1247714429@qq.com>

.github/workflows/test.yml

@@ -10,6 +10,7 @@ on:
     paths:
     - '**.rs'
     - '**/Cargo.*'
+    - '.github/workflows/**.yml'
 
 jobs:
   test:
@@ -33,6 +34,13 @@ jobs:
         toolchain: ${{ matrix.rust }}
         components: rustfmt, clippy
         default: true
+    - uses: actions-rs/cargo@v1
+      with:
+        command: fmt
+        args: -- --check
+    - uses: actions-rs/cargo@v1
+      with:
+        command: clippy
     - uses: actions-rs/cargo@v1
       with:
         command: check
@@ -40,7 +48,7 @@ jobs:
     - uses: actions-rs/cargo@v1
       with:
         command: test
-        args: --all-features --all-targets
+        args: --all-features --all-targets --all
     - uses: actions-rs/cargo@v1
       with:
         command: test
@@ -49,10 +57,3 @@ jobs:
       with:
         command: check
         args: --no-default-features
-    - uses: actions-rs/cargo@v1
-      with:
-        command: fmt
-        args: -- --check
-    - uses: actions-rs/cargo@v1
-      with:
-        command: clippy

calc-example/calc/src/parser.rs

@@ -624,7 +624,7 @@ fn parse_error() {
                 statements: [],
             },
             [
-                Diagnostic { position: 10, message: "unexpected character" },
+                Diagnostic { start: 10, end: 11, message: "unexpected character" },
             ],
         )"#]];
     expected.assert_eq(&actual);

salsa-2022-tests/tests/accumulate.rs

@@ -2,7 +2,6 @@
 //!
 //! * entities not created in a revision are deleted, as is any memoized data keyed on them.
 
-use salsa::DebugWithDb;
 use salsa_2022_tests::{HasLogger, Logger};
 
 use expect_test::expect;
@@ -70,7 +69,7 @@ struct Database {
 }
 
 impl salsa::Database for Database {
-    fn salsa_event(&self, event: salsa::Event) {}
+    fn salsa_event(&self, _event: salsa::Event) {}
 
     fn salsa_runtime(&self) -> &salsa::Runtime {
         self.storage.runtime()
@@ -174,7 +173,8 @@ fn get_a_logs_after_changing_b() {
         [
             "log_a(0 of 2)",
             "log_a(1 of 2)",
-        ]"#]]
+        ]
+    "#]]
     .assert_debug_eq(&logs);
     db.assert_logs(expect!["[]"]);
 }