Commit graph

48 commits

Author SHA1 Message Date
Niko Matsakis
11c55b804d
Update RFC0008-Remove-Garbage-Collection.md 2021-06-15 15:29:42 -04:00
Niko Matsakis
1bf5757255 link RFC to PR 2021-06-06 06:08:45 -04:00
Niko Matsakis
f7dd6b3219 remove tracing garbage collection support
It is not widely used and it makes it harder to evolve Salsa.
2021-06-06 06:06:03 -04:00
Niko Matsakis
67207d8d0d update with links to implementation 2021-05-27 20:24:38 -04:00
Niko Matsakis
08cc09f7e3 nits, sp 2021-05-15 09:35:09 -04:00
Niko Matsakis
be39f5d870
Apply suggestions from code review
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-15 09:26:28 -04:00
Niko Matsakis
54e092b984 fix title 2021-05-15 06:07:02 -04:00
Niko Matsakis
2b8ee2043d add RFC: Opinionated cancelation 2021-05-15 05:46:34 -04:00
bors[bot]
9a17f01d1b
Merge #261
261: modify RFC template to use FAQ format r=nikomatsakis a=nikomatsakis



Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
2021-05-15 09:28:54 +00:00
Niko Matsakis
ecf693e481 modify RFC template to use FAQ format 2021-05-15 05:28:02 -04:00
Christopher Biscardi
c17778e358 add links 2020-11-01 12:23:17 -08:00
Christopher Biscardi
5c1ebc22af update on_demand_inputs invalidation 2020-09-13 00:17:39 -07:00
Markus Westerlind
ce6428fbbd Lift the static restriction on the traits 2020-07-23 11:34:20 +02:00
Niko Matsakis
4974d649ec mention the plumbing 2020-07-07 10:07:47 +00:00
Niko Matsakis
da7c8b30db fix mdbook tests 2020-07-07 09:55:04 +00:00
Niko Matsakis
f7071dd137 RFC: remove RFC text about DependencySlot
It's simpler to just store a DatabaseKeyIndex. It may be somewhat
slower, we'll have to measure.  But we can add back in this other
design later if we want.
2020-07-05 20:13:29 +00:00
Niko Matsakis
8ca3ab56b5 update the mdbook documentation, introducing a diagram 2020-07-05 16:45:07 +00:00
Niko Matsakis
0a8c2038b5 RFC: remove link, linkcheck doesn't like it 2020-07-05 10:52:49 +00:00
Niko Matsakis
b1e3003c1e RFC: describe new bounds 2020-07-05 10:52:47 +00:00
Niko Matsakis
0b82d24514 RFC: describe 'static requirement 2020-07-05 10:52:43 +00:00
Niko Matsakis
b59dcc9145 RFC: describe in_db functions 2020-07-05 10:34:15 +00:00
Niko Matsakis
fad97eeb6a remove the DB parameter
This had two unexpected consequences, one unfortunate, one "medium":

* All `salsa::Database` must be `'static`. This falls out from
`Q::DynDb` not having access to any lifetimes, but also the defaulting
rules for `dyn QueryGroup` that make it `dyn QueryGroup + 'static`. We
don't really support generic databases anyway yet so this isn't a big
deal, and we can add workarounds later (ideally via GATs).

* It is now statically impossible to invoke `snapshot` from a query,
and so we don't need to test that it panics. This is because the
signature of `snapshot` returns a `Snapshot<Self>` and that is not
accessible to a `dyn QueryGroup` type. Similarly, invoking
`Runtime::snapshot` directly is not possible becaues it is
crate-private. So I removed the test. This seems ok, but eventually I
would like to expose ways for queries to do parallel
execution (matklad and I had talked about a "speculation" primitive
for enabling that).

* This commit is 99% boilerplate I did with search-and-replace. I also
rolled in a few other changes I might have preferred to factor out,
most notably removing the `GetQueryTable` plumbing trait in favor of
free-methods, but it was awkward to factor them out and get all the
generics right (so much simpler in this version).
2020-07-04 14:17:11 +00:00
Niko Matsakis
4bf46f5f24 RFC: describe new approach to runtime 2020-07-04 14:16:50 +00:00
Niko Matsakis
6e813441cb RFC: update to mention that salsa::requires is removed 2020-07-04 14:16:50 +00:00
Niko Matsakis
cc7bc54409 RFC: adjust because DatabaseKeyIndex are not part of public API 2020-07-04 14:16:50 +00:00
Niko Matsakis
0da53151c5 RFC: update to use index triples 2020-07-04 14:16:14 +00:00
Niko Matsakis
d1347d8854 RFC 6: Dynamic databases
Update book/src/rfcs/RFC0006-Dynamic-Databases.md

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Update book/src/rfcs/RFC0001-Query-Group-Traits.md

Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>

Update book/src/rfcs/RFC0006-Dynamic-Databases.md

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

fix lint warnings on RFC
2020-07-04 14:16:14 +00:00
Niko Matsakis
59ec6482e1 update the template and randomly adapt RFC0001 only 2020-07-04 14:16:14 +00:00
Niko Matsakis
b953732981 add RFC 4, 5 2020-06-27 10:25:20 +00:00
Niko Matsakis
baee86bc25 move the accepted RFCs to the book and describe a new process 2020-06-27 01:46:39 +00:00
Niko Matsakis
ebb3769ad2 document the database macro 2020-06-26 22:21:54 +00:00
Niko Matsakis
4b0c8a6368 move query groups to its own chapter 2020-06-26 22:21:53 +00:00
Matthijs Brobbel
a4d05c8c4b
Update plumbing.md
Fixed a small typo.
2020-06-26 16:40:32 +02:00
Niko Matsakis
1e33157648 fix mdbook tests 2020-06-24 15:12:02 +00:00
Niko Matsakis
6184b1df54 address matklad's points 2020-06-24 13:41:55 +00:00
Niko Matsakis
550c0c3db6 document the code we generate for a query group 2020-06-24 11:13:39 +00:00
Niko Matsakis
4643beee05 integrate mermaid support into the book 2020-06-24 09:53:33 +00:00
Geoff Shannon
294b12f719 Fix doc typos 2020-05-16 13:41:25 -07:00
Vlad-Shcherbina
fecec6bab2 Fix doc typo 2020-04-11 13:43:00 +02:00
Declan Kelly
564fa155d4 Correct mutability in on demand example, fix doc links
Fix query_mut documentation link

Fix more documentation links

More doc links
2019-10-05 18:30:42 -07:00
Niko Matsakis
25b54aa0b3 remove mention of the im crate 2019-09-24 06:51:17 -04:00
Niko Matsakis
8b2219c1e1 fix weird sentence 2019-09-24 06:29:30 -04:00
Niko Matsakis
2e9b418bbb rework book a little bit
- extend some of the empty sections, add a new common pattern
- also, show how to use anchors and include so we can test the sources
  for common patterns
2019-09-24 06:13:51 -04:00
Aleksey Kladov
3616014391
Apply suggestions from code review
Co-Authored-By: Niko Matsakis <niko@alum.mit.edu>
2019-09-24 12:08:13 +03:00
Aleksey Kladov
a798f1d918 Update src/runtime.rs
Co-Authored-By: bjorn3 <bjorn3@users.noreply.github.com>
2019-09-22 18:31:38 +03:00
Aleksey Kladov
ec5b92ea20 tests and docs for on-demand input pattern 2019-09-20 12:25:12 +03:00
Guanqun Lu
5eb6c6f0bd some random typo fixes 2019-08-23 00:54:29 +08:00
Niko Matsakis
e5d9409d46 introduce the basic structure of a book (very much a WIP) 2019-01-30 05:58:41 -05:00