Niko Matsakis
ce750dadf5
allow elided lifetimes in tracked fn return values
2024-05-30 09:40:47 -04:00
Niko Matsakis
b9ab8fcebd
rustfmt has opinions
2024-05-30 08:46:15 -04:00
Niko Matsakis
0ad0be8095
pacify the merciless clippy
2024-05-30 08:40:18 -04:00
Niko Matsakis
88b964d18d
use const _: () to disable clippy lints
2024-05-30 08:40:18 -04:00
Niko Matsakis
07d0ead9f4
return a NonNull instead of a &'db
...
In old code, we converted to a `&'db` when
creating a new tracked struct or interning,
but this value in fact persisted beyond the end
of `'db` (i.e., into the new revision).
We now refactor so that we create the `Foo<'db>`
from a `NonNull<T>` instead of a `&'db T`, and
then only create safe references when users
access fields.
This makes miri happy.
2024-05-30 01:59:49 -04:00
Niko Matsakis
81942f37e5
use Alloc not Box
...
to avoid uniqueness guarantees
2024-05-27 07:39:46 -04:00
Niko Matsakis
ce88a8f9ca
apply cargo fmt
2024-05-25 16:25:06 -04:00
Niko Matsakis
68502ab27f
'db all the things
2024-05-24 07:16:50 -04:00
Niko Matsakis
1560634f96
support methods with 'db lifetimes
2024-05-24 07:16:50 -04:00
Niko Matsakis
b005820494
add a derive for DebugWithDb
2024-05-24 07:16:50 -04:00
Niko Matsakis
4f4d01958f
generate a custom std::fmt::Debug impl
...
This leads less representation information
and in particular avoids serializing pointers.
2024-05-24 07:16:50 -04:00
Niko Matsakis
d98485d3cb
add a derive for salsa::Update
...
And a test for it. This is required if you
want to have structures in your tracked structs.
Looks we need one for salsa::DebugWithDb, too.
2024-05-24 07:16:50 -04:00
Niko Matsakis
2800076857
update to syn 2.0
2024-05-24 07:16:50 -04:00
Niko Matsakis
06b70975e9
impl Update/Send/Sync
...
and add dedicated tests for that
2024-05-24 07:16:50 -04:00
Niko Matsakis
b4b49fbd1b
split the Id conversion traits
...
We now have AsId (always present)
and FromId/LookupId (sometimes present).
AsId is no longer part of the
salsa public interface.
Replace the ad-hoc `salsa_id` etc methods with
calls to `AsId::as_id`.
2024-05-24 07:16:50 -04:00
Niko Matsakis
7519c3e2a6
extend IdentityInterner to be based on LookupId
2024-05-24 07:16:50 -04:00
Niko Matsakis
ab70786536
introduce LookupId trait
...
We are going to need it for tracked functions.
2024-05-24 07:16:50 -04:00
Niko Matsakis
cf2fa671f5
introduce IdLookup trait
...
We are going to need it for tracked functions.
2024-05-24 07:16:50 -04:00
Niko Matsakis
8d0f8fccbf
remove unnecessary uses of AsId
2024-05-24 07:16:50 -04:00
Niko Matsakis
d361e8adfb
add a 'db argument to SalsaStruct
2024-05-24 07:16:50 -04:00
Niko Matsakis
9607638d5d
permit interned structs with lifetimes
2024-05-24 07:16:50 -04:00
Niko Matsakis
9d8a60b617
parameterize salsa_struct module
2024-05-24 07:16:50 -04:00
Niko Matsakis
0b8c27bc30
rename from TrackedStruct to just Struct
...
this will let us use different packages
but the same struct name from salsa struct
2024-05-24 07:16:50 -04:00
Niko Matsakis
5095d79d13
return a pointer from interning, not just id
2024-05-24 07:16:50 -04:00
Niko Matsakis
d92f2aa0a5
factor out useful helper fn
2024-05-24 07:16:50 -04:00
Niko Matsakis
af94b253be
debug dump for interned struct tokens
2024-05-24 07:16:50 -04:00
Niko Matsakis
d6d522662c
have tracked struct intern its own keys
...
Previously tracked structs relied on an
interned ingredient to intern their keys.
But really it has more complex logic than we
need. Simpler to just remove it and duplicate
the basic concept.
2024-05-24 07:16:50 -04:00
Niko Matsakis
4822013523
permit interned data to take 'db lifetime
2024-05-24 07:16:50 -04:00
Niko Matsakis
d190bebcac
introduce helper functions
...
We'll need these for use with tracked functions
2024-05-24 07:16:50 -04:00
Niko Matsakis
97fc6a0920
rework interning to have a Configuration
...
This will permit GATs so that interned values
can carry lifetimes.
2024-05-24 07:16:50 -04:00
Niko Matsakis
54c9586b45
move interned-specific fns out of salsa struct
...
Salsa struct is already a grab-bag, best to keep
it to shared functionality.
2024-05-24 07:16:50 -04:00
Niko Matsakis
8ba6e606c0
generate configuration struct in salsa_struct
...
It will be shared between tracked structs and
interned structs.
2024-05-24 07:16:50 -04:00
Niko Matsakis
4f74037f41
pipe debug output through rustfmt
...
is there a nicer way to do this?!
2024-05-24 07:16:50 -04:00
Niko Matsakis
04e041b4a2
rework debugging to be more permanent
2024-05-24 07:16:50 -04:00
Niko Matsakis
fe4ff9816a
support db lifetimes in fields
2024-05-24 07:16:50 -04:00
Niko Matsakis
a84777d5a7
permit <'db> on tracked struct
...
tracked structs with `'db` carry a pointer
and not an id.
2024-05-24 07:16:50 -04:00
Niko Matsakis
e95c8b21fb
give fields a lifetime
2024-05-24 07:16:50 -04:00
Niko Matsakis
44a8a2f41c
make fn input/value a GAT
2024-05-24 07:16:50 -04:00
Niko Matsakis
b050bd874a
remove Key from Fn configuration
...
Just use salsa::Id for the most part.
2024-05-24 07:16:50 -04:00
Niko Matsakis
6e2647fa50
just take salsa::Id instead of id structs
2024-05-24 07:16:50 -04:00
Niko Matsakis
cb1a2bb75b
Revert "WIP permit 'db on tracked struct definitions (opt)"
...
This reverts commit 43b1b8ef3f98213279b9d0768847603299162f1f.
2024-05-24 07:16:50 -04:00
Niko Matsakis
b6311d8102
WIP permit 'db on tracked struct definitions (opt)
2024-05-24 07:16:50 -04:00
Niko Matsakis
5ce5e3c374
track and assert struct ingredient indices
...
We need a cheap way to compute field indices.
2024-05-24 07:16:50 -04:00
Niko Matsakis
79d24e0ad7
allow (but don't test) lifetime parameters
2024-05-24 07:16:50 -04:00
Niko Matsakis
ea1d452143
create a struct_map that encapsulates access
...
The internal API is now based around providing
references to the `TrackedStructValue`.
Documenting the invariants led to one interesting
case, which is that we sometimes verify a tracked
struct as not having changed (and even create
`&`-ref to it!) but then re-execute the function
around it.
We now guarantee that, in this case, the data
does not change, even if it has leaked values.
This is required to ensure soundness.
Add a test case about it.
2024-05-24 07:16:47 -04:00
Niko Matsakis
20cb307301
give trait more info about lifetime relationships
...
In particular, the ingredient and the database
have the same lifetime.
This will be useful later for safety conditions.
2024-05-24 07:15:40 -04:00
Niko Matsakis
a32078153b
separate marking the outputs as verified
...
There are 3 call-sites to this function:
* One of them has already marked the outputs
* One of them has no outputs
* The third does need to mark the outputs
2024-05-24 07:15:40 -04:00
Niko Matsakis
e24ace24eb
return &TrackedStructValue<C> from new_struct
...
This is a step towards the goal of keep a pointer
in the structs themselves.
2024-05-24 07:15:40 -04:00
Niko Matsakis
4533cd9e4b
adopt the Salsa 3.0 Update` trait
...
Right now, this doesn't change much except the
behavior in the event that `Eq` is not properly
implemented. In the future, it will enable
the use of references and slices and things.
2024-05-24 07:15:40 -04:00
Niko Matsakis
90597b18ab
remove stray eprintln
2024-04-12 04:57:41 -04:00
