mirror of
https://github.com/salsa-rs/salsa.git
synced 2025-01-15 17:49:46 +00:00
e0d07812fa
392: Allow creation of tracked methods r=nikomatsakis a=Skepfyr Fixes #319. This allows users to annotate impl blocks with `#[salsa::tracked]` and then create tracked methods by marking individual functions with `#[salsa::tracked]`. Note this requires your code that looks like: ```rust #[salsa::tracked(jar = Jar)] impl MyInput { #[salsa::tracked] fn tracked_fn(self, db: &dyn Db) -> u32 { self.field(db) * 2 } } ``` You get an error if you annotate a method with `#[salsa::tracked]` but forget to mark the impl block. It got messier than I was hoping but I think it turned out alright, this would look really pretty if we had [inherent associated types](https://github.com/rust-lang/rust/issues/8995), but we don't. Annoyingly even if that landed I think we'd still need the attribute on the impl block just so that it was possible to create the associated struct somewhere as you can't put types inside an impl block (and they aren't accessible if placed inside a function). Co-authored-by: Jack Rickard <jack.rickard@outlook.com> |
||
|---|---|---|
| .. | ||
| get-set-on-private-field.rs | ||
| get-set-on-private-field.stderr | ||
| lru_can_not_be_used_with_specify.rs | ||
| lru_can_not_be_used_with_specify.stderr | ||
| specify-does-not-work-if-the-key-is-a-salsa-input.rs | ||
| specify-does-not-work-if-the-key-is-a-salsa-input.stderr | ||
| specify-does-not-work-if-the-key-is-a-salsa-interned.rs | ||
| specify-does-not-work-if-the-key-is-a-salsa-interned.stderr | ||
| tracked_method_on_untracked_impl.rs | ||
| tracked_method_on_untracked_impl.stderr | ||