mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-02-03 17:44:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Add event for welcome page close

Browse source
This commit is contained in:
Joseph T. Lyons 2024-01-06 15:17:28 -05:00
parent cdd5cb16ed
commit 167a0b590f
2 changed files with 13 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
crates/editor/src/items.rs
View file

@ -866,7 +866,6 @@ impl Item for Editor {
} }
fn to_item_events(event: &EditorEvent, mut f: impl FnMut(ItemEvent)) { fn to_item_events(event: &EditorEvent, mut f: impl FnMut(ItemEvent)) {
dbg!(event);
match event { match event {
EditorEvent::Closed => f(ItemEvent::CloseItem), EditorEvent::Closed => f(ItemEvent::CloseItem),

54
crates/welcome/src/welcome.rs
View file

@ -14,7 +14,7 @@ use ui::{prelude::*, Checkbox};
use vim::VimModeSetting; use vim::VimModeSetting;
use workspace::{ use workspace::{
dock::DockPosition, dock::DockPosition,
item::{Item, ItemEvent, ItemHandle}, item::{Item, ItemEvent},
open_new, AppState, Welcome, Workspace, WorkspaceId, open_new, AppState, Welcome, Workspace, WorkspaceId,
}; };
@ -252,48 +252,20 @@ impl Render for WelcomePage {
impl WelcomePage { impl WelcomePage {
pub fn new(workspace: &Workspace, cx: &mut ViewContext<Workspace>) -> View<Self> { pub fn new(workspace: &Workspace, cx: &mut ViewContext<Workspace>) -> View<Self> {
let this = cx.new_view(|cx| WelcomePage { let this = cx.new_view(|cx| {
focus_handle: cx.focus_handle(), cx.on_release(|this: &mut Self, _, _| {
workspace: workspace.weak_handle(), this.telemetry.report_app_event("close welcome page", false);
telemetry: workspace.client().telemetry().clone(), })
_settings_subscription: cx.observe_global::<SettingsStore>(move |_, cx| cx.notify()), .detach();
});
this.on_release( WelcomePage {
cx, focus_handle: cx.focus_handle(),
Box::new(|cx| { workspace: workspace.weak_handle(),
this.update(cx, |this, _| { telemetry: workspace.client().telemetry().clone(),
this.telemetry.report_app_event("close welcome page", false); _settings_subscription: cx
}) .observe_global::<SettingsStore>(move |_, cx| cx.notify()),
}),
)
.detach();
// this.subscribe_to_item_events(
// cx,
// Box::new(|event: ItemEvent, cx| {
// // if event == ItemEvent::CloseItem {
// dbg!(event);
// // welcome.update(cx, |welcome, _| {
// // welcome
// // .telemetry
// // .report_app_event("close welcome page", false);
// // })
// // }
// }),
// )
// .detach();
cx.subscribe(&this, |_, welcome, event, cx| {
if *event == ItemEvent::CloseItem {
welcome.update(cx, |welcome, _| {
welcome
.telemetry
.report_app_event("close welcome page", false);
})
} }
}) });
.detach();
this this
} }