Apply terminal.foreground and terminal.background from theme (#14281)
Some checks are pending
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run

Release Notes:

- Fixed terminal colors not respecting the theme
([#11418](https://github.com/zed-industries/zed/discussions/11418)).
This commit is contained in:
Zak Johnson 2024-07-13 04:41:44 -07:00 committed by GitHub
parent 89fbd6528f
commit 3a410942b4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -656,12 +656,12 @@ impl Element for TerminalElement {
font_size: font_size.into(),
font_style: FontStyle::Normal,
line_height: line_height.into(),
background_color: None,
background_color: Some(theme.colors().terminal_background),
white_space: WhiteSpace::Normal,
// These are going to be overridden per-cell
underline: None,
strikethrough: None,
color: theme.colors().text,
color: theme.colors().terminal_foreground,
};
let text_system = cx.text_system();
@ -1141,8 +1141,8 @@ pub fn convert_color(fg: &terminal::alacritty_terminal::vte::ansi::Color, theme:
NamedColor::BrightMagenta => colors.terminal_ansi_bright_magenta,
NamedColor::BrightCyan => colors.terminal_ansi_bright_cyan,
NamedColor::BrightWhite => colors.terminal_ansi_bright_white,
NamedColor::Foreground => colors.text,
NamedColor::Background => colors.background,
NamedColor::Foreground => colors.terminal_foreground,
NamedColor::Background => colors.terminal_background,
NamedColor::Cursor => theme.players().local().cursor,
NamedColor::DimBlack => colors.terminal_ansi_dim_black,
NamedColor::DimRed => colors.terminal_ansi_dim_red,