mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-01-24 11:01:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

assistant2: Cancel pending completion when an error occurs (#23143)

Browse source 
This PR makes it so the pending completion is cleared when an error
occurs.

This makes it so `Thread::is_streaming()` will return `false` in the
error case (and thus hide the streaming indicator in the UI).

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2025-01-14 14:04:47 -05:00 committed by GitHub
parent c33eb012cf
commit 4febc7ea49
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/assistant2/src/thread.rs
View file

@ -361,7 +361,7 @@ impl Thread {
let result = stream_completion.await;
thread
.update(&mut cx, |_thread, cx| match result.as_ref() {
.update(&mut cx, |thread, cx| match result.as_ref() {
Ok(stop_reason) => match stop_reason {
StopReason::ToolUse => {
cx.emit(ThreadEvent::UsePendingTools);
@ -384,6 +384,8 @@ impl Thread {
SharedString::from(error_message.clone()),
)));
}
thread.cancel_last_completion();
}
})
.ok();